Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

Archive LGPU repo #147

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Archive LGPU repo #147

merged 4 commits into from
Feb 5, 2024

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Feb 5, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: This PR adds the archival notice to LGPU, in preparation of of making the repo read-only at v0.32.0.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link

github-actions bot commented Feb 5, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will the warning show up in the docs too?

@mlxd
Copy link
Member Author

mlxd commented Feb 5, 2024

Thanks! Will the warning show up in the docs too?

If the docs build succeeds, it will show up in latest. Will try to fix the failure, as not much info is given.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlxd!

README.rst Show resolved Hide resolved
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦣

@mlxd mlxd merged commit eaeece9 into main Feb 5, 2024
10 of 14 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants