This repository has been archived by the owner on Feb 5, 2024. It is now read-only.
Pin lightning.qubit dep to v0.31.0 #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
mlxd
added
the
ci:use-multi-gpu-runner
|
Here we are updating lightning to the most recent (master) version. By tackling this, and similar others, we should avoid such errors. |
vincentmr
reviewed
Aug 22, 2023
| @@ -188,7 +188,7 @@ def test_pauli_rotation_gradient(self, G, theta, tol, isBatch_obs, request): | |||
| dev_cpu = qml.device("default.qubit", wires=3) | |||
|
|
|||
| with qml.tape.QuantumTape() as tape: | |||
| qml.QubitStateVector(np.array([1.0, -1.0]) / np.sqrt(2), wires=0) | |||
| qml.StatePrep(np.array([1.0, -1.0]) / np.sqrt(2), wires=0) | |||
There was a problem hiding this comment.
Here we could parametrize the test over the state prep op since QubitStateVector should still be supported. If we go forward with #134, I will do that there.
Co-authored-by: Amintor Dusko <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Python tests are passing, nothing more to add, nice job! |
AmintorDusko
approved these changes
Aug 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: With the new design for lightning.qubit, until lightning.gpu can be merged into the new structure, we aim to pin to the previous LQ design. This PR pins
lightning.gpuCI builds to based on the v0.31.0 release tag of `lightning.qubit.Description of the Change: As above.
Benefits: Ensures builds work for the next release.
Possible Drawbacks:
Related GitHub Issues: