Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

MPI Sparse Hamiltonian for Adjoint Jacobian #128

Merged
merged 51 commits into from
Aug 24, 2023
Merged

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Jul 11, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@multiphaseCFD multiphaseCFD added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Jul 11, 2023
@multiphaseCFD multiphaseCFD changed the base branch from main to mpi_sparse_ham July 11, 2023 18:26
@mlxd
Copy link
Member

mlxd commented Aug 1, 2023

Can we rebase this PR against main and merge in the latest changes?

@multiphaseCFD multiphaseCFD changed the base branch from mpi_sparse_ham to main August 2, 2023 04:56
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@multiphaseCFD multiphaseCFD requested review from mlxd and removed request for mlxd August 8, 2023 15:33
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shuli - quick question

mpitests/test_adjoint_jacobian.py Outdated Show resolved Hide resolved
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @multiphaseCFD

@multiphaseCFD multiphaseCFD merged commit ad75124 into main Aug 24, 2023
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants