Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pasqal device #31
Add pasqal device #31
Changes from 8 commits
bd65c2a
2ef8615
6061280
24ec20a
78488e1
ea3e4bf
44ddf06
df68bdc
c6b7f6b
1fee81d
d105451
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another future option is to make use of the
ThreeDGridQubit
static methods, such asparallelep
andrect
to construct the array of qubits (https://github.com/lhenriet/Cirq/blob/125722761ca56a641db7e15c89303ed55f076441/cirq/pasqal/pasqal_qubits.py#L102)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we want to deal with this requirement when merging into master? The issue I see is that this fork has diverged from Cirq master (it hasn't been kept up to date).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this in a separate branch, and undocumented, until that fork is successfully merged in. I'll try to keep abreast of when that might happen. In the meantime, we can continue our next steps (developing a tutorial) using the holding branch