Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Facade tests #191

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Fix failing Facade tests #191

merged 3 commits into from
Aug 26, 2024

Conversation

Shiro-Raven
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (74bd315) to head (b5f436c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   99.44%   99.42%   -0.02%     
==========================================
  Files           8        8              
  Lines         358      350       -8     
==========================================
- Hits          356      348       -8     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alex-Preciado
Copy link
Contributor

Looks good to me!! Approving and merging

@Alex-Preciado Alex-Preciado merged commit bdd4180 into master Aug 26, 2024
8 of 9 checks passed
@Alex-Preciado Alex-Preciado deleted the ad/facade-tests-fixing branch August 26, 2024 17:18
@astralcai
Copy link
Contributor

[sc-72151]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants