bugfix: text fields with "%" can be edited successfully #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR updates formatted query to only use interpolation via
vsprintf
when there are parameters present. Parameterized queries are made in a number of places in the app but, critically, not when users are updating their fields directly. This allows parameters queries to be used everywhere in the app as before without limited which characters end users can put in their text fields.Steps to Verify
Setup:
On master branch,
field_a
cannot be successfully updated b/cvsprintf
thinks the%
is part of string interpolation (note: this is correct behavior for vsprintf).On the branch for this PR, the above fields can be updated without issue.