fix unitialized memory to allow more strict build flags #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankBoesing
suggested changes
Dec 1, 2021
| @@ -338,7 +338,7 @@ void USBHIDParser::parse() | |||
| p += *p + 3; | |||
| continue; | |||
| } | |||
| uint32_t val; | |||
| uint32_t val = 0; | |||
There was a problem hiding this comment.
That's the wrong fix. Yes, I guess the compiler optimized the double val =0 away, but it's not nice to read and lazy.
There should be a default case instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C:\Users\niteris.platformio\packages\framework-arduinoteensy\libraries\USBHost_t36\hid.cpp: In member function 'void USBHIDParser::parse()':
C:\Users\niteris.platformio\packages\framework-arduinoteensy\libraries\USBHost_t36\hid.cpp:361:20: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
usage_page = val;
^
C:\Users\niteris.platformio\packages\framework-arduinoteensy\libraries\USBHost_t36\hid.cpp: In member function 'void USBHIDParser::parse(uint16_t, const uint8_t*, uint32_t)':
C:\Users\niteris.platformio\packages\framework-arduinoteensy\libraries\USBHost_t36\hid.cpp:524:37: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
logical_max = signedval(val, tag);