Table fixes #61
Merged
Table fixes #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a strange problem with tables and selecting all content with <ctrl>-<a>. When the last node in the document is a table and the last table cell is empty, then pressing <CTRL>-<a> to select everyting only selects the very first node in the document. As soon as one of the conditions - table not the last node or last table cell not empty - is not met, <CTRL>-<a> selects all, as expected. We fix the problem by making sure some content is following the table and add an empty paragraph. When another solution is found we can remove this hack again. More information here: - ueberdosis/tiptap#2401 - ueberdosis/tiptap#3651
We would need quite some extra CSS for the `.column-resize-handle` for a questionable benefit. Disable it for now until we need it back and find a solution for the missing CSS. Example for the CSS to be added (touches also table and cell styles): https://tiptap.dev/api/nodes/table#resizable
reinhardt
approved these changes
Oct 16, 2023
thet
added a commit
that referenced
this pull request
Oct 23, 2023
Allow to select all (Ctrl-A, Command-A) with tables in certain conditions. Due to a tiptap/ProseMirror bug tables with some empty cells and no content preceding or following the table, selecting the whole table did not work. This fix makes sure that a non-empty paragraph is added at the end, if no other content is present at the end of the document. Follow-up from: - #61 More information here: - ueberdosis/tiptap#2401 - ueberdosis/tiptap#3651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains these fixes:
fix: Fix problem with table not selectable with ctrl-a
There is a strange problem with tables and selecting all content with ctrl-a. When the last node in the document is a table and the last table cell is empty, then pressing CTRL-a to select everyting only selects the very first node in the document. As soon as one of the conditions - table not the last node or last table cell not empty - is not met, CTRL-a selects all, as expected.
We fix the problem by making sure some content is following the table and add an empty paragraph. When another solution is found we can remove this hack again.
More information here:
maint: Disable horizontal table cell resizing.
We would need quite some extra CSS for the
.column-resize-handlefor a questionable benefit. Disable it for now until we need it back and find a solution for the missing CSS.Example for the CSS to be added (touches also table and cell styles):
https://tiptap.dev/api/nodes/table#usage
maint: Use a different webpack dev server port than the default Patternslib one.