Brilift: Use unreachable code trap

See sampsyo#343.
Pat-Lafon · Nov 4, 2024 · fd19001 · fd19001
1 parent 6b9390d
commit fd19001
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/brilift/src/translator.rs b/brilift/src/translator.rs
@@ -632,12 +632,11 @@ impl CompileEnv<'_> {
             if return_type.is_none() {
                 builder.ins().return_(&[]);
             } else {
-                // If the function has a return type
-                // Lets just trap since this must be dead code
-                builder.ins().trap(
-                    /* Some random trap code */
-                    cranelift_codegen::ir::TrapCode::TableOutOfBounds,
-                );
+                // An implicit return is illegal when there is a return type,
+                // so this code is unreachable.
+                builder
+                    .ins()
+                    .trap(cranelift_codegen::ir::TrapCode::UnreachableCodeReached);
             }
         }
     }