Skip to content

Commit

Permalink
Merge pull request #1500 from Particular/reword-api-comment
Browse files Browse the repository at this point in the history
Reword API comment
  • Loading branch information
SzymonPobiega authored Nov 20, 2024
2 parents 38d9df3 + 081dbb5 commit ee00690
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ protected override BrokerConnection GetBoundValue(BindingContext bindingContext)
certificateCollection.Add(certificate);
}

var connectionFactory = new ConnectionFactory("rabbitmq-transport", connectionConfiguration, certificateCollection, disableCertificateValidation, useExternalAuth, TimeSpan.FromSeconds(60), TimeSpan.FromSeconds(10), new List<(string, int, bool)>());
var connectionFactory = new ConnectionFactory("rabbitmq-transport", connectionConfiguration, certificateCollection, disableCertificateValidation, useExternalAuth, TimeSpan.FromSeconds(60), TimeSpan.FromSeconds(10), []);
var brokerConnection = new BrokerConnection(connectionFactory);

return brokerConnection;
Expand Down
9 changes: 5 additions & 4 deletions src/NServiceBus.Transport.RabbitMQ/RabbitMQTransport.cs
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,11 @@ public TimeSpan TimeToWaitBeforeTriggeringCircuitBreaker
/// </summary>
/// <remarks>
/// <para>
/// This customization is applied after any configured transport customizations, meaning that
/// any changes made here may override or conflict with previous transport-level adjustments.
/// Exercise caution, as modifying the message at this stage can lead to unintended behavior
/// downstream if the message structure or properties are altered in ways that do not align
/// When provided, the action is invoked after all other transport customizations have executed.
/// This means that any changes made by the native customization logic can override or conflict
/// with previous transport-level adjustments. This extension point should be used with caution,
/// as modifying a native message at this stage can lead to unintended behavior if the message
/// content or properties are altered in ways that do not align with expectations.
/// with expectations elsewhere in the system.
/// </para>
/// </remarks>
Expand Down

0 comments on commit ee00690

Please sign in to comment.