feat: add project tags create/list/delete #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ani-ps
reviewed
Apr 5, 2024
ani-ps
reviewed
Apr 5, 2024
commands/project/tags/delete/mod.ts
Outdated
| short: "Delete a project tag.", | ||
| long: ` | ||
| Delete a project by its name. If you don't provide a name, this command will | ||
| prompt you for one. |
There was a problem hiding this comment.
Looks like youre prompting both, projects and tags if they dont exists. Wonder if the long description should say both, instead of just name. Also, is name what we are using across the app? I feel like name is confusing since it is an id (project id) what it needs.
There was a problem hiding this comment.
Yeah, we delete by name. For tags it's a bit odd because we don't actually surface the id, and also the id is not team/project specific, so we match by name.
ani-ps
approved these changes
Apr 8, 2024
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #57