Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Merge vanilla default files with normal config files #463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: Merge vanilla default files with normal config files #463

wants to merge 1 commit into from

Conversation

Leguan16
Copy link
Contributor

@Leguan16 Leguan16 commented Aug 13, 2024 •
edited
Loading

I do not like the current solution to the "how-to vanilla" page. Thats why I am proposing a refactor that merges the two files with adding a vanilla field to config options that alter the vanilla behavior.

only-merge-items-horizontally:
  vanilla: "true"
  default: "false"
  description: >-
    Prevents merging items that are not on the same y level, preventing potential
    visual artifacts.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 13, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview 871500d

@Leguan16 Leguan16 marked this pull request as ready for review January 3, 2025 16:28
@Leguan16
Copy link
Contributor Author

Leguan16 commented Jan 3, 2025

should be open for reviews now!

olijeffers0n
olijeffers0n requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@olijeffers0n olijeffers0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this implementation a lot more, thanks! One thing, could you please rename this vanilla within the ConfigDocBlock to something more like showVanillaValue or something slightly more self explanatory. Good to merge then

@Leguan16
Copy link
Contributor Author

Alright will do! I also like it way more than the current version.

@Leguan16
Copy link
Contributor Author

I like this implementation a lot more, thanks! One thing, could you please rename this vanilla within the ConfigDocBlock to something more like showVanillaValue or something slightly more self explanatory. Good to merge then

changed the param name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olijeffers0n olijeffers0n olijeffers0n requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leguan16 @olijeffers0n