-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document vanilla breaking changes #326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 25, 2024
zlataovce
reviewed
Jun 3, 2024
olijeffers0n
requested changes
Jun 6, 2024
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Co-authored-by: Joseph Burton <[email protected]>
olijeffers0n
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to set the foundation for the "How to get as close as possible to a vanilla experience" page.
I took #21 (comment) as a reference for the initial work. Some of the settings listed don't exist anymore.
I am sure those are not the only ones. Therefore, I would appreciate it if we can find more settings together as it would be a huge effort for one person to go through every setting.
Ideally, we would add a little text to why these changes have been made and stuff like that. Please provide feedback in this direction. The design is also not final, but I think that would be the logical design choice? With listing every file that contains vanilla breaking changes as separate config.
I also think we should include a link at each setting, linking to the reference. See
duplicate-uuid
for an initial design.