feat: announce waterfall eol #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notTamion
reviewed
Mar 2, 2024
zlataovce
approved these changes
Mar 3, 2024
|
do we really need to copy in the whole theme when we (at least from a quick glance) only modify one file? |
Unfortunately when you eject it includes all those components. I tried deleting some and had some issues however I believe that may have been caused by something else I have now fixed, so I’ll have a lool |
natereprogle
suggested changes
Mar 3, 2024
natereprogle
reviewed
Mar 3, 2024
zlataovce
reviewed
Mar 5, 2024
zlataovce
reviewed
Mar 9, 2024
There was a problem hiding this comment.
eolMessage should probably be renamed to eol_message to stay consistent with other front matter properties
Co-authored-by: Matouš Kučera <[email protected]>
MiniDigger
force-pushed
the
feat/sunsetting
branch
from
9e34871
to
7960c93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.