Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ItemDamageEvents called for 0 damage #11555

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix ItemDamageEvents called for 0 damage #11555

wants to merge 2 commits into from

Conversation

notTamion
Copy link
Contributor

@notTamion notTamion requested a review from a team as a code owner November 1, 2024 16:31
@Lulu13022002
Copy link
Contributor

This break negative damage amount that is possible with enchantment component. I'm not sure if the event/api should run in this case too.

@notTamion
Copy link
Contributor Author

For later:

  1. do we want the event to be called in case of negative damage?
  2. should we allow setDamage and other methods which damage the itemstack to deal negative damage? as this might break some plugins that are relying on those methods not being able to deal negative damage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Paper PR Queue
Status: Awaiting review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notTamion @Lulu13022002