Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ItemStack#effectiveName #11469

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ItemStack#effectiveName #11469

wants to merge 2 commits into from
+62 −0

Conversation

masmc05
Copy link
Contributor

@masmc05 masmc05 commented Oct 5, 2024

Adds a new method which returns the name of an itemstack which the player sees in their inventory. Takes into account any data components exactly as vanilla.

Unlike ItemStack#displayName, does not add additional brackets etc

@masmc05 masmc05 requested a review from a team as a code owner October 5, 2024 01:30
electronicboy
electronicboy previously approved these changes Oct 9, 2024
View reviewed changes
@lynxplay
Copy link
Contributor

lynxplay commented Oct 9, 2024

Duplicate of #9050

@lynxplay lynxplay marked this as a duplicate of #9050 Oct 9, 2024
@lynxplay lynxplay dismissed electronicboy’s stale review October 9, 2024 21:38

Not so fast buckaroo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electronicboy electronicboy electronicboy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Paper PR Queue
Status: Awaiting final testing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masmc05 @lynxplay @electronicboy