Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/scoreboard delegate #11453

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix/scoreboard delegate #11453

wants to merge 3 commits into from

Conversation

Intybyte
Copy link

Fixes #11296

@Intybyte Intybyte requested a review from a team as a code owner September 30, 2024 15:29
@masmc05
Copy link
Contributor

masmc05 commented Sep 30, 2024

I don't think you should update the upstream...

@Intybyte Intybyte closed this Sep 30, 2024
@Intybyte Intybyte reopened this Sep 30, 2024
Leguan16
Leguan16 reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Leguan16 Leguan16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, if nms/bukkit files are modified FQN should be used instead of imports to reduce the diff. Also, every line that is added needs to be marked with a comment. For more information refer to the CONTRIBUTING.md :)

@masmc05
Copy link
Contributor

masmc05 commented Sep 30, 2024

Don't manually change patch files, you need to make changes, amend it to the latest commit in paper-server and then rebuild patches

Machine-Maker
Machine-Maker previously requested changes Oct 1, 2024
View reviewed changes
patches/server/1065-Create-Limited-set-for-Entity.patch Outdated Show resolved Hide resolved
patches/server/1065-Create-Limited-set-for-Entity.patch Outdated Show resolved Hide resolved
patches/server/1065-Create-Limited-set-for-Entity.patch Outdated Show resolved Hide resolved
electronicboy
electronicboy approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@electronicboy electronicboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do ponder if we should move the set over to mc-util, but, otherwise, this lgtm

@lynxplay lynxplay dismissed Machine-Maker’s stale review October 20, 2024 23:48

What you gonna do about it?

@Intybyte
Copy link
Author

what are the advantages of using a delegate in this case?

@electronicboy
Copy link
Member

it's a reusable generic container wrapper class

@lynxplay
Copy link
Contributor

The fact that we can reuse this type for different set implementations. The previous implementation would lock the type into the speed/contracts of hashset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulu13022002 Lulu13022002 Lulu13022002 left review comments

@Amejonah1200 Amejonah1200 Amejonah1200 left review comments

@Leguan16 Leguan16 Leguan16 left review comments

@imDaniX imDaniX imDaniX requested changes

@electronicboy electronicboy electronicboy approved these changes

@lynxplay lynxplay lynxplay approved these changes

@Machine-Maker Machine-Maker Awaiting requested review from Machine-Maker

Assignees
No one assigned
Labels
None yet
Projects
Paper PR Queue
Status: PR Party candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entity#getScoreboardTags directly exposes the Set<String>
9 participants
@Intybyte @masmc05 @electronicboy @lynxplay @Machine-Maker @imDaniX @Lulu13022002 @Amejonah1200 @Leguan16