Skip to content

Commit

Permalink
[thirdparty] libraries will now be maintain alphabetical order
Browse files Browse the repository at this point in the history
  • Loading branch information
PanosK92 committed Jan 13, 2025
1 parent 719be40 commit b1729dd
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
2 changes: 0 additions & 2 deletions runtime/Core/GeometryProcessing.h
Original file line number Diff line number Diff line change
Expand Up @@ -395,8 +395,6 @@ namespace spartan::geometry_processing

static void optimize(std::vector<RHI_Vertex_PosTexNorTan>& vertices, std::vector<uint32_t>& indices)
{
register_meshoptimizer();

size_t vertex_count = vertices.size();
size_t index_count = indices.size();

Expand Down
9 changes: 9 additions & 0 deletions runtime/Core/Settings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,16 @@ namespace spartan
void Settings::RegisterThirdPartyLib(const string& name, const string& version, const string& url)
{
lock_guard<mutex> lock(mutex_register);

m_third_party_libs.emplace_back(name, version, url);

// maintain alphabetical order
sort(m_third_party_libs.begin(), m_third_party_libs.end(),
[](const third_party_lib& a, const third_party_lib& b)
{
return a.name < b.name;
}
);
}

const vector<third_party_lib>& Settings::GetThirdPartyLibs()
Expand Down

0 comments on commit b1729dd

Please sign in to comment.