[Rendering] Calibrated some lighting parameters

PanosK92 · Oct 21, 2023 · 507bf1b · 507bf1b
1 parent 6a5b273
commit 507bf1b
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/data/shaders/light_image_based.hlsl b/data/shaders/light_image_based.hlsl
@@ -93,7 +93,7 @@ float4 mainPS(Pixel_PosUv input) : SV_TARGET
     // try to compute some sort of ambient light that makes sense
     float3 light_ambient = 1.0f;
     {
-        light_ambient = buffer_light.intensity_range_angle_bias.x * 0.2f * surface.occlusion;
+        light_ambient = buffer_light.intensity_range_angle_bias.x * 0.1f * surface.occlusion;
     }
 
     // compute specular energy

diff --git a/runtime/Rendering/Renderer.cpp b/runtime/Rendering/Renderer.cpp
@@ -207,10 +207,6 @@ namespace Spartan
         SetOption(Renderer_Option::Debug_Lights,             1.0f);
         SetOption(Renderer_Option::Debug_Physics,            0.0f);
         SetOption(Renderer_Option::Debug_PerformanceMetrics, 1.0f);
-        // Buggy or unused options
-        //SetOption(Renderer_Option::PaperWhite,             150.0f);                                            // nits
-        //SetOption(RendererOption::DepthOfField,            1.0f);                                              // this is depth of field from ALDI, so until I improve it, it should be disabled by default.
-        //SetOption(RendererOption::VolumetricFog,           1.0f);                                              // disable by default because it's not that great, I need to do it with a voxelised approach.
 
         // resources
         CreateConstantBuffers();

diff --git a/runtime/World/Components/Light.cpp b/runtime/World/Components/Light.cpp
@@ -275,7 +275,7 @@ namespace Spartan
 
         // This magic values are chosen empirically based on how the lights
         // types in the LightIntensity enum should look in the engine
-        const float magic_value_a = 50.0f;
+        const float magic_value_a = 100.0f;
         const float magic_value_b = 0.025f;
 
         // convert lumens to power (in watts) assuming all light is at 555nm

diff --git a/runtime/World/World.cpp b/runtime/World/World.cpp
@@ -801,7 +801,7 @@ namespace Spartan
     {
         Vector3 camera_position = Vector3(8.7844f, 1.5f, -4.1412f);
         Vector3 camera_rotation = Vector3(7.4f, -65.5f, 0.0f);
-        create_default_world_common(camera_position, camera_rotation, LightIntensity::sky_sunlight_morning_evening, "project\\music\\riders_on_the_storm_fredwreck_remix.mp3");
+        create_default_world_common(camera_position, camera_rotation, LightIntensity::sky_sunlight_noon, "project\\music\\riders_on_the_storm_fredwreck_remix.mp3");
 
         // environment
         {