[pull] main from osrf:main #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Update to use 22.04 and test python 3.10 * fixup python version
…roups on the host that aren't permissible on the target but you'd like best-effort. Signed-off-by: Tully Foote <[email protected]>
* feat: add group-add plugin Signed-off-by: Amadeusz Szymko <[email protected]> Co-authored-by: Amadeusz Szymko <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
Fixes #223 Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
* move to actions/checkout@v3 * move to actions/setup-python@v4 * Pin back urllib3<2 due to regression docker/docker-py#3113 * Remove old workaround which upstream has merged a fix for. * upgrade codecov action to v3 * upgrade to coactions/setup-xvfb@v1 Signed-off-by: Tully Foote <[email protected]>
Adding codecov.yml to enable comments back
* Allow the override of nvidia selection Signed-off-by: Amadeusz Szymko <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Amadeusz Szymko <[email protected]>
* Added extension ordering functionality based on changes made in https://github.com/stonier/groot_rocker.git Co-authored-by: Alex Youngs <[email protected]>
* Separate out pre and post user snippets. Regular snippets can assume root access. Post snippets can assume USER is set to the final user. * add basic tests for user snippets
* Create directory structure when writing files * Add test for directory structure * Added in additional handling for paths outside the directory Co-authored-by: Alex Youngs <[email protected]>
Add link to novnc_rocker
* Allow binary files to be copied into the build context Co-authored-by: Alex Youngs <[email protected]>
The plane launch file points to an old ROS 1 demo which was replaced in osrf/drone_demo#18
To test executions returns true
Short term work around for #259
Followup to #261
Signed-off-by: Tully Foote <[email protected]>
* Basic rocker config to install and enable different rmw layers
Empy 4.1 added support for extension markup @((...)), which makes rocker fail when using passing the `--user` argument as the snippet uses @(( in some places.
* Implement glvnd version option and default policy * remove unused arg options
* Add IPC support to RockerExtension - Introduced a new IPC class that extends RockerExtension to handle IPC namespace options. - Implemented `get_name` to return the 'ipc' identifier. - Added `get_docker_args` method to generate Docker IPC arguments based on CLI input. - Included a `get_preamble` method that returns an empty string as no preamble is needed. This commit enables the use of IPC-related Docker arguments in Rocker configurations. * ⚡ basic test for ipc for high coverage --------- Co-authored-by: Tully Foote <[email protected]>
New interface from #85
This is a dangerous practice becuse the default values could be mutated. And it should always be passed in. Supercedes #286
* add: type hints for parser argument --------- Co-authored-by: Tully Foote <[email protected]>
* add: link to pixi_rocker repo * docs: Add links to external rocker extensions * docs: add section on externally maintained rocker wrappers
* Barebones extension * Add expected format to help message * Add tests for ulimit extension --------- Co-authored-by: Tully Foote <[email protected]>
…aking up all disk space. Especially for the tests. Also add option to top level for cleaning up the image on the CLI
The call to get_docker_client in setUpClass will fail if docker is not available on the host.
This test calls extend_cli_parser, which will fail if docker is not available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )