Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soyoungjeong.yml #37

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d394987
Create dayoung.yaml
cdy0510 Oct 11, 2019
5391268
Merge pull request #1 from cdy0510/master
cdy0510 Oct 11, 2019
95f6fe4
DEVFEST이미지 추가, 문구 수정, 페이스북 링크 추가
Oct 16, 2019
9cbab63
Merge pull request #2 from GDG-Seoul/develop
cdy0510 Oct 16, 2019
81f784b
Update README.md
cdy0510 Oct 16, 2019
6ca0151
Delete pandelis.yaml
cdy0510 Oct 16, 2019
f34e252
Create yeonheehan.yaml
hanyeonhee Oct 17, 2019
3945e49
Merge pull request #3 from hanyeonhee/master
cdy0510 Oct 17, 2019
c2855c0
Create my yaml
rickiepark Oct 17, 2019
12b9b68
Create ywkim.yaml
hjkkhj123 Oct 17, 2019
5a45841
Update ywkim.yaml
hjkkhj123 Oct 17, 2019
7892b89
Update README.md
hjkkhj123 Oct 17, 2019
3c24a90
Update README.md
hjkkhj123 Oct 17, 2019
0c7a1cc
Update README.md
hjkkhj123 Oct 17, 2019
afc1fca
Update README.md
hjkkhj123 Oct 17, 2019
b28c1c6
Update README.md
hjkkhj123 Oct 17, 2019
f1718d3
Merge pull request #6 from hjkkhj123/master
cdy0510 Oct 17, 2019
da4af9f
Merge pull request #7 from hjkkhj123/patch-1
cdy0510 Oct 17, 2019
1173374
update emoji and image
rickiepark Oct 18, 2019
3ff8f14
Merge pull request #4 from rickiepark/master
cdy0510 Oct 18, 2019
a9c6d49
Update README.md
hjkkhj123 Oct 18, 2019
e7e8afc
Update README.md
cdy0510 Oct 18, 2019
2012192
Merge pull request #8 from hjkkhj123/iframe-test
cdy0510 Oct 18, 2019
027f1c3
improve readme markdown
Shinye Oct 18, 2019
de38629
Improve readme markdown
Shinye Oct 18, 2019
49f8f7e
create shinye guestbook
Shinye Oct 18, 2019
ec4a0e5
Create shinye guestbook
Shinye Oct 18, 2019
80a7b5f
Update README.md
cdy0510 Oct 19, 2019
39f7bd3
문구수정
cdy0510 Oct 19, 2019
9bf7a59
soyoung's 방명록
soyoungjeong Oct 20, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
_site
.sass-cache
.idea/*
104 changes: 73 additions & 31 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,63 +1,105 @@
# Workshop Guestbook 📓
# DevFest Seoul 2019 방명록 🥳

Hey welcome to this workshops guestbook! By signing this guestbook we will explore many of the core concepts of GitHub.
By the end of this workshop you will have forked a repo, created a commit, made a pull request and signed your name on the guestbook.
안녕하세요! Commit and Candy 액티비티에 오신것을 환영합니다!<br />개발자들의 축제인만큼 재밌는 Commit을 날려보지 않겠어요?

# Signing the guestbook
아래 설명을 차근차근 따라오시다보면 PR(Pull Request)도 어렵지 않아요!<br />여러분이 작성한 PR이 `merge` 되면, GDG Seoul Github pages에 인사말이 등록됩니다.

## Using GitHub.com

### Forks

GitHub let's you adapt any piblic repository using forks. Forks copy the entire repository to your profile so that you have ownership and
controll. This let's you add features to a project without needing to request direct access to a repository.
### 방명록 양식 (미리 복사해주세요!)

Let's fork this repository to get started:
- 프로필 url이 없을 경우 https://avatar.tobi.sh/tobiaslins.svg?text=GDG 좌측 parameter에 본인의 이니셜로 변경해주세요.
- 예시)`https://avatar.tobi.sh/tobiaslins.svg?text=DY`
- emoji 필드는 여기에서 찾아 복사 붙여넣기 해주세요 (키보드의 기본 이모지를 사용하셔도 됩니다.) 👉 [emojipedia.org](https://emojipedia.org/)
- SNS 계정은 아이디(@이하 메일 제외)만 적어주시면 됩니다. 예시) cdy0510

```
---
name: {{이름}}
image: {{프로필 사진 url}}
emoji: 🥳
message: {{인사말}}
facebook: {{계정 아이디 / 없으면 해당 라인 삭제하셔도 됩니다.}}
twitter: {{계정 아이디 / 없으면 해당 라인 삭제하셔도 됩니다.}}
github: {{계정 아이디 / 없으면 해당 라인 삭제하셔도 됩니다.}}
---
```



# 📝 방명록 등록하기

## GitHub.com을 사용합니다.

### 1. Fork 하기

우선 PR을 하기 위해 현재 repository(이하 저장소)를 자신의 계정으로 포크 해주세요. Fork는 현재 저장소를 자신의 저장소로 전체 복사하는 것을 의미합니다. Fork한 저장소는 본인 계정의 저장소가 되어 직접 소스를 관리할 수 있습니다. 이를 통해 원래 저장소에 직접 액세스 할 필요 없이 프로젝트에 기능을 추가 할 수 있습니다.

그럼, 이 저장소를 Fork하는 것으로 시작해볼까요?

![fork](.github/images/fork.gif)

### Making a change
[![Inline docs](https://githubbadges.com/fork.svg?user=GDG-Seoul&repo=DevFest-Seoul-2019-guestbook)](https://github.com/GDG-Seoul/DevFest-Seoul-2019-guestbook/fork)

The repository will now exist as a seperate repository under your GitHub profile. From your fork go to the `/_guestbook` folder and click on **Create new file**.
Name this file **yourname.yaml**. Then paste the bellow template into your file and replace it with your details. You can delete any fields you dont want to fill except *name* and *image*
위 버튼을 눌러 포크하기



### 2. 변경 사항 만들기(방명록 추가하기)

저장소는 이제 GitHub 프로필 아래에 별도의 저장소로 존재합니다.

포크에서 `/ _guestbook` 폴더로 가서 **Create new file**을 클릭해 새 파일을 만들어주세요.
이 파일 이름을 **{yourname}.yaml**로 해주세요. 그런 다음 아래 양식을 파일에 붙여 넣고 자신의 정보로 바꿉니다. *name* 및 *image*를 제외하고 필요하지 않은 필드는 삭제할 수 있습니다.

```
---
name: Pandelis
image: https://avatar.tobi.sh/tobiaslins.svg?text=PZ
emoji: 🐼
message: Hey! I hope you're enjoying the workshop.
twitter: PandelisZ
github: PandelisZ
name: 조다영
image: https://avatar.tobi.sh/tobiaslins.svg?text=DY
emoji: 🥳
message: 안녕하세요! GDG Seoul 최고!
facebook: cdy0510
twitter:
github: cdy0510
---
```

![fork](.github/images/createfile.gif)

> If you don't wish to use a photo of yourself leve the placeholder image and add your initials as `?text=PZ` for example.
> 자신의 사진을 사용하지 않으려면 https://avatar.tobi.sh/tobiaslins.svg 에 parameter로 이니셜을 추가해주세요. `?text=DY`

> emoji 필드는 여기에서 찾아 복사 붙여넣기 해주세요(키보드의 기본 이모지를 사용하셔도 됩니다.) 👉 [emojipedia.org](https://emojipedia.org/)

> You can find your favorite emoji at [emojipedia.org](https://emojipedia.org/) and paste it into the emoji field

### Commiting

At the bottom of the new file page you'll be able to submit this change as a **commit**. Scroll to the bottom of the page and enter the commit details.
Commit messages should be short and descriptive so that others can tell what you're changing or adding.
### 3. Commit하기

새 파일 만들기 페이지에서 이제 수정된 내용을 `commit`할 수 있습니다. 페이지 하단에서 커밋 세부 내용을 채워주시고, **Commit new file** 버튼을 클릭해주세요.
커밋 메시지는 짧고 구체적이어야 다른 사람들이 변경하거나 추가 한 내용을 알 수 있습니다.

![commit](.github/images/commit.gif)


### Submitting a pull requst

Now that you have made your desired changes to the repo you can submit them **upstream** (the original repository). The way we do this within the [GitHub flow](https://guides.github.com/introduction/flow/) is by creating a pull request on the upstream repository. In this case the upstream repository is the original repository you
forked. This is shown on your repo as **forked from:** at the top of the repository page.
### 4. PR(Pull request) 제출하기

원하는 내용을 변경 했으므로 **upstream** (원래 저장소)에 PR을 제출할 수 있습니다. [GitHub Flow](https://guides.github.com/introduction/flow/)
upstream에 PR을 제출하면 내 코드를 반영할 수 있습니다.

upstream이란, 내가 fork했던 원래 저장소를 의미합니다.

To submit a pull request navigate to the original upstream repository and go to the **Pull requests** tab and click **New pull request**. If GitHub does not automatically detect
your fork you can click on *compare across forks*. Then create the pull reqeust
내 저장소 페이지에서 저장소 이름 아래를 보면 **forked from :** 으로 표시됩니다.<br />PR을 제출하려면 **Pull request** 탭을 누르고, **New pull request** 버튼을 누르세요.

GitHub가 자동으로 감지하지 못하는 경우 *compare across forks*를 클릭해주세요. 그 다음 PR을 생성하세요.

base repository는 GDG Seoul의 저장소가 될 것이고, head repository는 자신이 수정한 저장소의 브랜치가 될 것입니다.
PR은 `master` 쪽으로 제출해주시면 됩니다.

![pull request](.github/images/pullrequest.gif)


### Congrats :tada:

You've sucessfully creted a pull request! You're changes will now have to be reviewed. If you're filled out your details correctly your pull request will be approved and you will show up on the
guestbook.
### 축하합니다!! :tada:

여러분은 성공적으로 PR을 제출하셨습니다!!
방명록을 올바르게 입력하셨다면, 담당자가 PR을 승인하고 곧 페이지에 표시될 것입니다.
4 changes: 2 additions & 2 deletions _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ collections:
- guestbook

workshop:
name:
github: https://github.com/PandelisZ/workshop-guestbook
name: DevFest Seoul 2019
github: https://github.com/GDG-Seoul/DevFest-Seoul-2019-guestbook
8 changes: 8 additions & 0 deletions _guestbook/dayoung.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
name: Dayoung Cho
image: https://avatars1.githubusercontent.com/u/15723999?s=460&v=4
emoji: 🥳
message: DevFest Seoul에 오신것을 환영합니다! GDG Seoul 많이 사랑해주세요!!
facebook: cdy0510
github: cdy0510
---
10 changes: 10 additions & 0 deletions _guestbook/haesunpark.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@

---
name: 박해선
image: https://avatar.tobi.sh/tobiaslins.svg?text=HS
emoji: 🔥
message: 안녕하세요! GDG Seoul 최고!
facebook: haesunrpark
twitter:
github: rickiepark
---
8 changes: 0 additions & 8 deletions _guestbook/pandelis.yaml

This file was deleted.

8 changes: 8 additions & 0 deletions _guestbook/shinye.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
name: Shinye Song
image: https://avatars0.githubusercontent.com/u/10671079?s=460&v=4
emoji: ⚾️
message: 즐거운 DevFest! 모두 즐거운 시간 되시면 좋겠어요 <3 (키움히어로즈 한국시리즈 화이팅!ㅎㅎㅋ)
facebook: iamsysong
github: Shinye
---
7 changes: 7 additions & 0 deletions _guestbook/soyoungjeong.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
name: 정소영
image: https://avatar.tobi.sh/tobiaslins.svg?text=JSY
emoji: 😇
message: GDG Seoul 너무 좋아요!!
github: soyoungjeong
---
8 changes: 8 additions & 0 deletions _guestbook/yeonheehan.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
name: 한연희
image: https://avatars3.githubusercontent.com/u/33242880?s=460&v=4
emoji: ⭐️
message: 안녕하세요! GDG Seoul 최고!!
facebook: jess0884
github: hanyeonhee
---
9 changes: 9 additions & 0 deletions _guestbook/ywkim.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
name: 김영우
image: https://avatar.tobi.sh/tobiaslins.svg?text=YW
emoji: 🥳
message: GDG 최고 DevFest 최고
facebook:
twitter:
github: hjkkhj123
---
Binary file added images/devfest-logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 11 additions & 6 deletions index.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
title: GitHub Workshop Guestbook
title: DevFest Seoul 2019 Guestbook
---
<!DOCTYPE html>
<html>
Expand All @@ -16,8 +16,9 @@
<section id="guestbook">
<div class="container">
<div class="section-header">
<h1 role="section-heading">{{site.workshop.name}} Workshop Guestbook</h1>
<h3><a href="{{site.workshop.github}}">Sign the guestbook</a></h3>
<img src="images/devfest-logo.png" alt="devfest로고">
<h1 role="section-heading">Seoul 2019 방명록🥳</h1>
<h3><a href="{{site.workshop.github}}">PR 제출하러 가기🕊</a></h3>
</div>

<div class="guestbook-content">
Expand All @@ -32,6 +33,10 @@ <h4>{{guest.message}}</h4>
<hr/>
<div class="guestbook-social">

{% if guest.facebook %}
<a href="https://facebook.com/{{guest.facebook}}" alt="Facebook"><i class="fab fa-facebook"></i></a>
{% endif %}

{% if guest.twitter %}
<a href="https://twitter.com/{{guest.twitter}}" alt="Twitter"><i class="fab fa-twitter"></i></a>
{% endif %}
Expand All @@ -55,11 +60,11 @@ <h4>{{guest.message}}</h4>
<section class="join" id="join-large">
<div class="container">
<div class="join-content">
<h3 role="section-heading">Sign the workshop guestbook!</h3>
<h3 role="section-heading">PR(pull request)제출하고 사탕받아가세요!</h3>
<div class="flag">
<img src="/images/flag.png" alt="">
<img src="images/flag.png" alt="">
</div>
<a href="{{site.workshop.github}}" class="button button-white">Sign the guestbook!</a>
<a href="{{site.workshop.github}}" class="button button-white">PR 제출하러 가기🕊</a>
</div>
</div>
</section>
Expand Down