Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add additional error handling to some upgrade assurance modules #561

Merged
merged 3 commits into from
May 16, 2024
Merged

feat: Add additional error handling to some upgrade assurance modules #561

merged 3 commits into from
May 16, 2024

Conversation

acelebanski
Copy link
Collaborator

Description

In customer projects we were using local copies of the following modules:

  • panos_readiness_checks.py
  • panos_snapshot_report.py

They had some additional Try Except blocks that were not present in public modules. This PR aims to introduce them.

Motivation and Context

#559

How Has This Been Tested?

These changes were introduced in local libraries used earlier in Upgrade Automation playbooks.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski added the enhancement New feature or request label Apr 16, 2024
@acelebanski acelebanski linked an issue Apr 16, 2024 that may be closed by this pull request
Modules used as libraries in upgrade automation playbooks #559
Closed
@acelebanski acelebanski marked this pull request as ready for review May 16, 2024 10:48
@acelebanski acelebanski merged commit c64cd79 into develop May 16, 2024
16 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@semantic-release-bot
chore(release): 2.21.0
20008d1 
## [2.21.0](v2.20.0...v2.21.0) (2024-09-16)

### Features

* Add additional error handling to some upgrade assurance modules ([#561](#561)) ([c64cd79](c64cd79))

### Bug Fixes

* **panos_security_rule:** state merged with existing values ([#570](#570)) ([db6c32c](db6c32c))
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@semantic-release-bot
chore(release): 2.21.0
5a14857 
## [2.21.0](v2.20.0...v2.21.0) (2024-09-16)

### Features

* Add additional error handling to some upgrade assurance modules ([#561](#561)) ([c64cd79](c64cd79))

### Bug Fixes

* **panos_security_rule:** state merged with existing values ([#570](#570)) ([db6c32c](db6c32c))
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@semantic-release-bot
chore(release): 2.21.0
d0be815 
## [2.21.0](v2.20.0...v2.21.0) (2024-09-16)

### Features

* Add additional error handling to some upgrade assurance modules ([#561](#561)) ([c64cd79](c64cd79))

### Bug Fixes

* **panos_security_rule:** state merged with existing values ([#570](#570)) ([db6c32c](db6c32c))
@alperenkose alperenkose deleted the upgrade-automation-local-libraries branch September 24, 2024 08:08
github-actions bot pushed a commit to alperenkose/pan-os-ansible that referenced this pull request Sep 24, 2024
@semantic-release-bot
chore(release): 2.20.0
6b3d984 
## [2.20.0](v2.19.1...v2.20.0) (2024-09-24)

### Features

* Add additional error handling to some upgrade assurance modules ([PaloAltoNetworks#561](https://github.com/alperenkose/pan-os-ansible/issues/561)) ([c64cd79](c64cd79))
* Add new option to panos_active_in_ha module ([PaloAltoNetworks#560](https://github.com/alperenkose/pan-os-ansible/issues/560)) ([a2870f5](a2870f5))

### Bug Fixes

* Add 'parent_interface' parameter for l2/l3 subinterface modules ([PaloAltoNetworks#552](https://github.com/alperenkose/pan-os-ansible/issues/552)) ([73c28a8](73c28a8))
* new release for failed ci ([3872708](3872708))
* requirements.txt update python version and remove hashes ([905b1eb](905b1eb))
* **panos_facts.py:** Fixed virtual systems fact name ([PaloAltoNetworks#558](https://github.com/alperenkose/pan-os-ansible/issues/558)) ([0d0fd6d](0d0fd6d))
* **panos_security_rule:** state merged with existing values ([PaloAltoNetworks#570](https://github.com/alperenkose/pan-os-ansible/issues/570)) ([db6c32c](db6c32c))
github-actions bot pushed a commit to alperenkose/pan-os-ansible that referenced this pull request Sep 25, 2024
@semantic-release-bot
chore(release): 2.20.0
c3d2498 
## [2.20.0](v2.19.1...v2.20.0) (2024-09-25)

### Features

* Add additional error handling to some upgrade assurance modules ([PaloAltoNetworks#561](https://github.com/alperenkose/pan-os-ansible/issues/561)) ([c64cd79](c64cd79))
* Add new option to panos_active_in_ha module ([PaloAltoNetworks#560](https://github.com/alperenkose/pan-os-ansible/issues/560)) ([a2870f5](a2870f5))
* ee ci for development ([97c31ba](97c31ba))

### Bug Fixes

* Add 'parent_interface' parameter for l2/l3 subinterface modules ([PaloAltoNetworks#552](https://github.com/alperenkose/pan-os-ansible/issues/552)) ([73c28a8](73c28a8))
* new release for failed ci ([3872708](3872708))
* requirements.txt update python version and remove hashes ([905b1eb](905b1eb))
* **panos_facts.py:** Fixed virtual systems fact name ([PaloAltoNetworks#558](https://github.com/alperenkose/pan-os-ansible/issues/558)) ([0d0fd6d](0d0fd6d))
* **panos_security_rule:** state merged with existing values ([PaloAltoNetworks#570](https://github.com/alperenkose/pan-os-ansible/issues/570)) ([db6c32c](db6c32c))
github-actions bot pushed a commit to alperenkose/pan-os-ansible that referenced this pull request Sep 25, 2024
@semantic-release-bot
chore(release): 2.20.0
1caaec0 
## [2.20.0](v2.19.1...v2.20.0) (2024-09-25)

### Features

* Add additional error handling to some upgrade assurance modules ([PaloAltoNetworks#561](https://github.com/alperenkose/pan-os-ansible/issues/561)) ([c64cd79](c64cd79))
* Add new option to panos_active_in_ha module ([PaloAltoNetworks#560](https://github.com/alperenkose/pan-os-ansible/issues/560)) ([a2870f5](a2870f5))
* ee ci for development ([97c31ba](97c31ba))
* test ee ci for release ([a7605af](a7605af))

### Bug Fixes

* Add 'parent_interface' parameter for l2/l3 subinterface modules ([PaloAltoNetworks#552](https://github.com/alperenkose/pan-os-ansible/issues/552)) ([73c28a8](73c28a8))
* new release for failed ci ([3872708](3872708))
* requirements.txt update python version and remove hashes ([905b1eb](905b1eb))
* **panos_facts.py:** Fixed virtual systems fact name ([PaloAltoNetworks#558](https://github.com/alperenkose/pan-os-ansible/issues/558)) ([0d0fd6d](0d0fd6d))
* **panos_security_rule:** state merged with existing values ([PaloAltoNetworks#570](https://github.com/alperenkose/pan-os-ansible/issues/570)) ([db6c32c](db6c32c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperenkose alperenkose alperenkose approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modules used as libraries in upgrade automation playbooks
2 participants
@acelebanski @alperenkose