Skip to content

Commit

Permalink
fix!: gathered_filter to process regex correctly
Browse files Browse the repository at this point in the history
Removed backslash(\) escape char from shlex to avoid escaping
and properly processing regex expressions.
  • Loading branch information
alperenkose committed Sep 24, 2024
1 parent 0fdd990 commit 0410fa5
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion plugins/module_utils/panos.py
Original file line number Diff line number Diff line change
Expand Up @@ -1200,6 +1200,18 @@ def _get_default_value(self, obj, key):

return default_value

def _shlex_split(self, logic):
"""Split string using shlex.split without escape char
Escape char '\' is removed from shlex class to correctly process regex.
"""
lex = shlex.shlex(logic, posix=True)
lex.whitespace_split = True
lex.commenters = ''
lex.escape = ''

return list(lex)

def matches_gathered_filter(self, item, logic):
"""Returns True if the item and its contents matches the logic given.
Expand All @@ -1223,7 +1235,7 @@ def matches_gathered_filter(self, item, logic):
evaler = []

pdepth = 0
logic_tokens = shlex.split(logic)
logic_tokens = self._shlex_split(logic)
token_iter = iter(logic_tokens)
while True:
end_parens = 0
Expand Down

0 comments on commit 0410fa5

Please sign in to comment.