Manage button fixes

[utkarshpra78]

What kind of change does this PR introduce?

changes in the CSS of orgListCard

Issue Number:

Fixes #2431

Did you add tests for your changes?

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Other information
now the manage button does not overlap with address

Have you read the contributing guide?

Summary by CodeRabbit

Release Notes

• New Features

  • Updated the pull request target branch validation to ensure it aligns with the develop branch.

• Bug Fixes

  • Removed outdated configuration files that may have caused inconsistencies in the IDE setup.

• Chores

  • Downgraded specific dependencies to ensure compatibility and stability of the project.

• Style

  • Adjusted the height of the organization card for improved layout and spacing.

[coderabbitai]

Walkthrough

The pull request modifies the GitHub Actions workflow in .github/workflows/pull-request.yml by changing the target branch validation condition from develop-postgres to develop and updating the corresponding error message. Additionally, several .idea configuration files are deleted, which removes IDE-specific settings and project structure definitions. The package.json file sees multiple dependencies downgraded, and the CSS file OrgListCard.module.css has an updated height property for the .orgCard class.

Changes

File	Change Summary
.github/workflows/pull-request.yml	Updated target branch condition and error message in Check-Target-Branch job.
.idea/.gitignore	Deleted file; previously ignored specific IDE-related files.
.idea/inspectionProfiles/Project_Default.xml	Deleted file; removed inspection profile settings for the project.
.idea/modules.xml	Deleted file; removed project structure and module management settings.
.idea/talawa-admin.iml	Deleted file; removed web module configuration settings.
.idea/vcs.xml	Deleted file; removed version control settings for the project.
package.json	Downgraded versions of several dependencies.
src/components/OrgListCard/OrgListCard.module.css	Increased height property for .orgCard class.

Assessment against linked issues

Objective	Addressed	Explanation
"Manage" button should be placed slightly below (issue #2431)	❌	The changes do not address the layout issue described.

Possibly related PRs

• fixed the eslint checker #2318: Modifies the .github/workflows/pull-request.yml file, updating the Check-Target-Branch job, similar to the main PR.
• fix: pull-request.yml to ignore actions on ignore-sensitive-files-pr and Introspection workflow #2391: Updates the .github/workflows/pull-request.yml file, adding conditions to the Check-Target-Branch job, aligning with the main PR's changes.
• feat: Workflow changes which will label issues automatically as per #2256 #2390: Introduces changes to the .github/workflows/pull-request.yml file, relating to workflow logic modifications similar to the main PR.

Suggested labels

ignore-sensitive-files-pr

Suggested reviewers

• palisadoes
• varshith257

Poem

In the garden of code, we hop and we play,
Adjusting our branches, come what may.
With heights that we tweak, and files that we shed,
The "Manage" button waits, for the fix up ahead! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

1. The overall code coverage drops below the target threshold of the repository
2. Any file in the pull request has code coverage levels below the repository threshold
3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

1. comments in this PR or
2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

1. arbitrators of future discussions with other contributors about the validity of your changes
2. point of contact for evaluating the validity of your work
3. person who verifies matching issues by others that should be closed.
4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

1. PRs with issues not assigned to you will be closed by the reviewer
2. Fix the first comment in the PR so that each issue listed automatically closes

Other

1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
2. Read the CONTRIBUTING.md file make

[github-actions]

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between fb913e1 and 9033ef8.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (8)

• .github/workflows/pull-request.yml (1 hunks)
• .idea/.gitignore (0 hunks)
• .idea/inspectionProfiles/Project_Default.xml (0 hunks)
• .idea/modules.xml (0 hunks)
• .idea/talawa-admin.iml (0 hunks)
• .idea/vcs.xml (0 hunks)
• package.json (4 hunks)
• src/components/OrgListCard/OrgListCard.module.css (1 hunks)

💤 Files with no reviewable changes (5)

• .idea/.gitignore
• .idea/inspectionProfiles/Project_Default.xml
• .idea/modules.xml
• .idea/talawa-admin.iml
• .idea/vcs.xml

🔇 Additional comments (1)

src/components/OrgListCard/OrgListCard.module.css (1)

4-4: Verify the layout changes across different scenarios.

Please ensure these layout changes work correctly:

1. With maximum length addresses
2. Across all responsive breakpoints
3. With different card content variations

✅ Verification successful

Layout changes appear to be well-handled across different scenarios

The verification shows that:

1. The component handles long content appropriately with text truncation (ellipsis) for organization name, description, and address
2. The CSS includes responsive breakpoints that properly adjust the layout for mobile screens (< 580px)
3. The height is dynamically calculated and switches to unset on mobile, preventing content overflow issues

The implementation includes:

• Text overflow handling via -webkit-line-clamp for descriptions and addresses
• Flexible content containers with proper spacing
• Mobile-first responsive design that restructures the card layout

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for other components that might use OrgListCard
rg -l "OrgListCard" --type tsx --type jsx

# Look for any custom card height overrides
rg "orgCard.*height" --type css

Length of output: 103

---

Script:

#!/bin/bash
# Search for files containing OrgListCard with proper file extensions
rg -l "OrgListCard" -g "*.tsx" -g "*.jsx" -g "*.js"

# Look for related CSS modules or stylesheets
fd -e css -x grep -l "height"

# Check for any responsive styles or media queries in the component's CSS
cat src/components/OrgListCard/OrgListCard.module.css

Length of output: 7965

[coderabbitai]

🛠️ Refactor suggestion

While this fixes the immediate issue, consider a more flexible solution.

The height increase prevents overlap but might not scale well with varying address lengths. A more maintainable approach would be to use flexbox for dynamic content flow.

Consider this alternative implementation:

.orgCard {
  background-color: var(--bs-white);
  margin: 0.5rem;
-  height: calc(120px + 2.55rem);
+  display: flex;
+  flex-direction: column;
+  min-height: calc(120px + 2rem);
  padding: 1rem;
  border-radius: 8px;
  outline: 1px solid var(--bs-gray-200);
  position: relative;
}

.orgCard .innerContainer {
  display: flex;
+  flex: 1;
}

.orgCard .innerContainer .content {
  flex: 1;
  margin-left: 1rem;
  width: 70%;
  margin-top: 0.7rem;
+  display: flex;
+  flex-direction: column;
+  gap: 0.5rem;
}

.address {
-  overflow: hidden;
-  display: -webkit-box;
-  -webkit-line-clamp: 1;
-  line-clamp: 1;
-  -webkit-box-orient: vertical;
+  display: flex;
+  flex-direction: column;
  align-items: center;
+  margin-bottom: 2rem;  /* Ensure space for button */
}

.orgCard button {
  position: absolute;
  bottom: 1rem;
  right: 1rem;
  z-index: 1;
+  margin-top: auto;  /* Push button to bottom */
}

This solution:

1. Uses flexbox for dynamic content flow
2. Allows address to wrap naturally
3. Maintains consistent spacing between elements
4. Scales better with different content lengths

Committable suggestion skipped: line range outside the PR's diff.

[coderabbitai]

💡 Codebase verification

⚠️ Potential issue

Unnecessary dependency downgrades should be reverted

The downgraded versions don't have any security vulnerabilities, but these changes are:

• Unrelated to the PR's objective of fixing CSS overlap in orgListCard
• Not justified by any compatibility requirements (peer dependencies are compatible)
• Introducing potential regression risks without clear benefits

Please revert the following downgrades to maintain the latest stable versions:

• @mui/x-charts: ^7.22.1 → ^7.22.2
• @types/react: ^18.3.3 → ^18.3.12
• eslint-plugin-import: ^2.30.0 → ^2.31.0
• sass: ^1.80.6 → ^1.80.7

🔗 Analysis chain

Unnecessary dependency downgrades detected.

These dependency downgrades seem unrelated to the PR's objective of fixing the CSS overlap issue in the orgListCard component:

• @mui/x-charts: ^7.22.2 → ^7.22.1
• @types/react: ^18.3.12 → ^18.3.3
• eslint-plugin-import: ^2.31.0 → ^2.30.0
• sass: ^1.80.7 → ^1.80.6

Please keep the changes focused on addressing the CSS overlap issue. If these downgrades are intentional, provide the rationale for making these changes.

Let's verify if the downgraded versions have any known security issues:

Also applies to: 122-122, 136-136, 149-149

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for security advisories for the downgraded packages

# Check for security advisories
for package in "@mui/x-charts" "@types/react" "eslint-plugin-import" "sass"; do
  echo "Checking $package..."
  gh api graphql -f query="
    query {
      securityVulnerabilities(first: 5, ecosystem: NPM, package: \"${package}\") {
        nodes {
          advisory {
            summary
            severity
            publishedAt
          }
          vulnerableVersionRange
          firstPatchedVersion {
            identifier
          }
        }
      }
    }"
done

# Check package compatibility
echo "Checking package compatibility..."
npm info "@mui/[email protected]" peerDependencies
npm info "@types/[email protected]" peerDependencies

Length of output: 2582