Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov upload #716

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sostock
Copy link
Collaborator

@sostock sostock commented Apr 24, 2024

This uses the codecov/codecov-action action for uploading to codecov instead of the deprecated julia-actions/julia-uploadcodecov. Hopefully, this fixes the codecov upload that seems to have broken recently.

@sostock sostock marked this pull request as ready for review April 24, 2024 13:44
@giordano
Copy link
Collaborator

giordano commented Apr 24, 2024

This will stop working at some point. We need to move to codecov/codecov-action@v3 and an admin of this repo to set up a codecov token.

@sostock
Copy link
Collaborator Author

sostock commented Apr 25, 2024

It looks like it already stopped working without a token.

@giordano
Copy link
Collaborator

My point is that codecov/codecov-action@v3 will stop working when Nodejs v16 will be retired in github actions in a few months. We can go on with this PR right now, but later this year we'll be again without codecov working.

@sostock
Copy link
Collaborator Author

sostock commented Apr 25, 2024

We can go on with this PR right now, but later this year we'll be again without codecov working.

I think merging this PR won’t do anything, the upload doesn’t work with this PR either. But I can change it to codecov-action@v4 (I thought v3 would work without token, that’s why I chose it). Then we only need an admin to add the token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants