-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Julia <1.6 #553
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=======================================
Coverage 88.19% 88.20%
=======================================
Files 16 16
Lines 1449 1441 -8
=======================================
- Hits 1278 1271 -7
+ Misses 171 170 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Should we make a release before merging this? There are some changes since last version: v1.11.0...adf24e7 |
I am slightly in favor of releasing a new version before merging this, because then people on Julia 1.0 still get #530 (which one could call a bugfix). The other changes since v1.11.0 are feature additions, so IMO it doesn’t make a difference whether they are released for Julia 1.0 or not. What do you think about this? |
Sounds good to me. I just noticed that in #533 I put some |
I just removed them. |
The tests that are added in #551 reveal that some things don’t work correctly on Julia 1.0.
Julia 1.6 is the LTS release (since the release of Julia 1.7.0 on 2021-11-30), so support for older versions can be removed.