Round Trip Printing. update tests for repr and show methods #470
Conversation
|
@sostock i would appreciate if you could have a peek at this when you get a chance |
Co-authored-by: Sebastian Stock <[email protected]>
Co-authored-by: Sebastian Stock <[email protected]>
Co-authored-by: Sebastian Stock <[email protected]>
Co-authored-by: Sebastian Stock <[email protected]>
Co-authored-by: Sebastian Stock <[email protected]>
Co-authored-by: Sebastian Stock <[email protected]>
|
thanks a bunch! |
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
- Coverage 83.77% 82.98% -0.80%
==========================================
Files 16 16
Lines 1344 1340 -4
==========================================
- Hits 1126 1112 -14
- Misses 218 228 +10
Continue to review full report at Codecov.
|
| else | ||
| @test string(typeof(1.0m/s)) == | ||
| "Quantity{Float64,𝐋 𝐓^-1,FreeUnits{(m, s^-1),𝐋 𝐓^-1,nothing}}" | ||
| "Quantity{Float64, Unitful.Dimensions{(Unitful.Dimension{:Length}(1//1), Unitful.Dimension{:Time}(-1//1))}(), FreeUnits{(Unitful.Unit{:Meter, Unitful.Dimensions{(Unitful.Dimension{:Length}(1//1),)}()}(0, 1//1), Unitful.Unit{:Second, Unitful.Dimensions{(Unitful.Dimension{:Time}(1//1),)}()}(0, -1//1)), Unitful.Dimensions{(Unitful.Dimension{:Length}(1//1), Unitful.Dimension{:Time}(-1//1))}(), nothing}}" |
There was a problem hiding this comment.
This (and some other tests) would need to be changed to match the old printing of type parameters (no spaces after commas), that’s why that @static if VERSION ≥ v"1.6.0-DEV.770" exists. But IMO we could just delete these tests since the printing isn’t customized anymore.
also adds a test so that the output printed to stdout can be copy pasted (roundtripped) back into REPL
supercedes #467