Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ancient greek dict and fonts #12041

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fangquinlan
Copy link

No description provided.

Add ancient Greek fonts from greekfontsociety, with the font license being OFL
Add ancient Greek fonts from Google fonts, with the font license being OFL
Copy link

paddle-bot bot commented May 2, 2024

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented May 2, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jzhang533
Copy link
Collaborator

有人知道, doc/fonts 下的这些字体文件是怎么被使用到的吗?

@GreatV
Copy link
Collaborator

GreatV commented May 7, 2024

有人知道, doc/fonts 下的这些字体文件是怎么被使用到的吗?

据我所知,好像就画图(可视化)的时候用到。

@fangquinlan
Copy link
Author

有人知道, doc/fonts 下的这些字体文件是怎么被使用到的吗?

据我所知,好像就画图(可视化)的时候用到。

可以用这些字体来生成训练用的文字图片素材

@jzhang533
Copy link
Collaborator

jzhang533 commented May 9, 2024

因为历史原因,在仓库里放了不少的字体文件,我觉得需要重新 review 这么做是否合适。
另外,关于这些字体的版权和来源,有一些说明吗?

@fangquinlan
Copy link
Author

因为历史原因,在仓库里放了不少的字体文件,我觉得需要重新 review 这么做是否合适。 另外,关于这些字体的版权和来源,有一些说明吗?

https://fonts.google.com/specimen/Open+Sans
https://www.greekfontsociety-gfs.gr/typefaces/19th_century

都遵循Open Font License

如果你觉得有问题,可以不通过字体,通过dict就行

@jzhang533
Copy link
Collaborator

如果是这样的话。因为现在已经有不少字体已经 vendor in 在仓库里了, PaddleOCR 的部分功能还依赖于这样的做法。所以我觉得新增的字体,现在 vendor in 也没问题。

为了更加合规,你需要在 doc/fonts 目录下,新增一个 README 文件,来说明一下(用英文),你新增的字体的来源和版权,就可以合入了。

@loganrooks
Copy link

Is there any update on this? Trying to OCR some texts with ancient Greek with this and hoping it'd be an improvement over tesseract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants