Mission feasibility checks: improve correctness of docs, escpecially around MIS_DIST_1WP #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfuhrer
force-pushed
the
pr-improve-mission-feasibility-docs
branch
from
6d2d337
to
6391328
Compare
…around MIS_DIST_1WP Signed-off-by: Silvan Fuhrer <[email protected]>
sfuhrer
force-pushed
the
pr-improve-mission-feasibility-docs
branch
from
6391328
to
5540a9a
Compare
|
No flaws found |
| @@ -76,18 +76,20 @@ For more information about mission planning, see: | |||
|
|
|||
| ## Mission Feasibility Checks | |||
|
|
|||
| PX4 runs some basic sanity checks to determine if a mission is feasible when it is uploaded, and when the vehicle is first armed. | |||
| PX4 runs some basic sanity checks to determine if a mission is feasible when it is uploaded and before executing a mission. | |||
There was a problem hiding this comment.
FMI Does this prevent switching to mission mode or you switch and the mission is in some kind of paused state?
There was a problem hiding this comment.
It prevents switching into Mission and will instead switch to Hold.
hamishwillee
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Thanks @sfuhrer ! Merging but might make post process changes based on your answer to https://github.com/PX4/PX4-user_guide/pull/3424/files#r1825185926
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs around mission feasibility are a bit outdated, especially since PX4/PX4-Autopilot#23568.
Related PR in PX4 for param description: PX4/PX4-Autopilot#23873