Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ drop php 8.1 #8

Merged
merged 1 commit into from
Aug 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/.git* export-ignore
/.php-cs-fixer.* export-ignore
/CHANGELOG.md export-ignore
/docs/ export-ignore
/phpstan*.neon export-ignore
/phpunit.xml.dist export-ignore
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,18 @@ jobs:
strategy:
matrix:
php:
- '8.1'
- '8.2'
- '8.3'
include:
- description: 'Lowest'
php: '8.1'
php: '8.2'
composer_option: '--prefer-lowest'
- description: 'Symfony 6.4'
php: '8.2'
symfony: 6.4.*
- description: 'Symfony 7.0'
- description: 'Symfony 7.1'
php: '8.3'
symfony: 7.0.*
symfony: 7.1.*
name: PHP ${{ matrix.php }} tests (${{ matrix.description }})
steps:
- name: Checkout
Expand Down
5 changes: 2 additions & 3 deletions .php-cs-fixer.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@
->setRules([
'@Symfony' => true,
'@Symfony:risky' => true,
'@PHP71Migration:risky' => true,
'@PHPUnit75Migration:risky' => true,
'ordered_imports' => true,
'@PHP82Migration' => true,
'@PHPUnit100Migration:risky' => true,
'declare_strict_types' => false,
'native_function_invocation' => ['include' => ['@all']],
])
Expand Down
7 changes: 0 additions & 7 deletions CHANGELOG.md

This file was deleted.

10 changes: 5 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@
}
],
"require": {
"php": "^8.1",
"symfony/form": "^6.4 || ^7.0",
"symfony/framework-bundle": "^6.4 || ^7.0"
"php": "^8.2",
"symfony/form": "^6.4 || ^7.1",
"symfony/framework-bundle": "^6.4 || ^7.1"
},
"require-dev": {
"phpunit/phpunit": "^11.3",
"simple-bus/message-bus": "^6.0",
"symfony/messenger": "^6.4 || ^7.0"
"simple-bus/message-bus": "^6.3",
"symfony/messenger": "^6.4 || ^7.1"
},
"extra": {
"branch-alias": {
Expand Down
14 changes: 9 additions & 5 deletions phpunit.xml.dist
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
<?xml version="1.0" encoding="UTF-8"?>

<phpunit bootstrap="vendor/autoload.php" colors="true">
<phpunit
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/schema/11.2.xsd"
bootstrap="vendor/autoload.php"
colors="true"
>
<testsuites>
<testsuite name="PUGXBusFormBundle test suite">
<directory suffix="Test.php">tests</directory>
<directory>tests</directory>
</testsuite>
</testsuites>
<coverage>
<source>
<include>
<directory>src</directory>
</include>
</coverage>
</source>
</phpunit>
2 changes: 1 addition & 1 deletion src/Form/Messenger/AbstractBusType.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function __construct(private Bus $bus)
*/
public function buildForm(FormBuilderInterface $builder, array $options): void
{
if (isset($options['data']) && is_object($options['data'])) {
if (isset($options['data']) && \is_object($options['data'])) {
$builder->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) use ($options): void {
$this->handle($event, $options['data']);
});
Expand Down
2 changes: 1 addition & 1 deletion src/Form/SimpleBus/AbstractBusType.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public function __construct(private Bus $bus)
*/
public function buildForm(FormBuilderInterface $builder, array $options): void
{
if (isset($options['data']) && is_object($options['data'])) {
if (isset($options['data']) && \is_object($options['data'])) {
$builder->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) use ($options): void {
$this->handle($event, $options['data']);
});
Expand Down
Loading