Solved discrepancy in JJZ vs LW weights #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small error in the usage of the
np.gradient
function which was the source of the discrepancy in the different methods of estimating social welfare weights. Should be of the formnp.gradient(f_array, x_grid)
rather than justnp.gradient(f_array)
, which led to themtr_prime
estimates being off by a factor of 10 in the JJZ estimates (our iot.z grid had spacing of $10 by default).