Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved discrepancy in JJZ vs LW weights #33

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

john-p-ryan
Copy link
Contributor

There was a small error in the usage of the np.gradient function which was the source of the discrepancy in the different methods of estimating social welfare weights. Should be of the form np.gradient(f_array, x_grid) rather than just np.gradient(f_array), which led to the mtr_prime estimates being off by a factor of 10 in the JJZ estimates (our iot.z grid had spacing of $10 by default).

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.37%. Comparing base (10985c1) to head (90e3345).
Report is 36 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (10985c1) and HEAD (90e3345). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (10985c1) HEAD (90e3345)
unittests 3 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #33       +/-   ##
===========================================
- Coverage   72.81%   49.37%   -23.45%     
===========================================
  Files           3        3               
  Lines         103      160       +57     
===========================================
+ Hits           75       79        +4     
- Misses         28       81       +53     
Flag Coverage Δ
unittests 49.37% <100.00%> (-23.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants