Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared ALB WAF #799

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Shared ALB WAF #799

merged 2 commits into from
Jan 16, 2025

Conversation

farski
Copy link
Member

@farski farski commented Jan 13, 2025

Adds a WAF to the shared ALB. Does not change the Dovetail Router ALB.

Meant to mimic the setup/rule that we currently have deployed.

This shouldn't be deployed until the existing WAF is torn down.

# Properties:
# ResourceArn: !Ref Alb
# WebACLArn: !GetAtt Waf.Arn
Waf:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to put this in its own template, so we can more easily share it between this ALB and the DT ALB?

@farski farski merged commit d2dc466 into main Jan 16, 2025
4 checks passed
@farski farski deleted the waf branch January 16, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant