-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Drop python 3.8-3.9, upgrade deps, use ruff format #429
Conversation
@@ -23,30 +23,29 @@ repository = "https://github.com/prql/pyprql" | |||
version = "0.12.1" | |||
|
|||
[tool.poetry.dependencies] | |||
python = "^3.8" | |||
python = "^3.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped this all the way to 3.10 since otherwise requires careful management of ipython dependency
Colab is on 3.10, which is some standard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
Bumped this all the way to 3.10 since otherwise requires careful management of ipython dependency
Colab is on 3.10, which is some standard
Hmmm, I don't know if it's worth dropping Python 3.9 just for that.
Isn't Colab based on 3.10 because python3 on Ubuntu 22.04 is 3.10?
https://launchpad.net/ubuntu/jammy/+package/python3
That has nothing to do with the release cycle of Python itself (since Ubuntu LTS is released every two years)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's related to Ubuntu: https://colab.google/articles/py3.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the context!
In any case, I don't know if there's any justification for dropping Python 3.9, given that duckdb, pyarrow and polars support 3.9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it's not ideal. But pandas etc have dropped 3.9, and it seems like we're going to need to do some dependency surgery to make ipython work with it — I'm mostly thinking whether that's worthwhile...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why the pandas version is relevant here.
pandas does not seem a dependency of IPython.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I just mean that pandas
is a big library that others follow — it's not like every other library support 3.9 except for us. Does that make more sense?
I think unless someone wants to do the work to make it py-3.8 compatible, it's a net benefit to merge this... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think unless someone wants to do the work to make it py-3.8 compatible, it's a net benefit to merge this...
I don't understand why you treat Python 3.8 and 3.9 the same, Python 3.9 is still supported right?
@@ -23,30 +23,29 @@ repository = "https://github.com/prql/pyprql" | |||
version = "0.12.1" | |||
|
|||
[tool.poetry.dependencies] | |||
python = "^3.8" | |||
python = "^3.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why the pandas version is relevant here.
pandas does not seem a dependency of IPython.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The badge shown in the README needs to be updated.
3.8 & 3.9 are both difficult to get work; they require making custom |
Given that upstream jupysql supports Python 3.9, I am not sure if your argument makes sense. In my opinion this is simply a limitation due to current CI and poetry, not a limitation of the Python package itself. |
I agree it's surprising. And I'm sure it's possible to support 3.8. It's just a tradeoff of whether it's worth the investment. Big fan of |
No description provided.