Add handle blocks #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duddino
force-pushed
the
add_syncblocks
branch
from
53aedfa
to
ad4d841
Compare
panleone
requested changes
Oct 21, 2024
There was a problem hiding this comment.
left some comments.
I tested the PR in PIVX-Labs/MyPIVXWallet#430.
First run handle_transaction_internal failed and the error "Couldn't handle transaction" was thrown. Second run everything worked and I synced with correct balance
Duddino
force-pushed
the
add_syncblocks
branch
from
ad4d841
to
7b23069
Compare
panleone
requested changes
Oct 28, 2024
panleone
requested changes
Oct 28, 2024
Duddino
force-pushed
the
add_syncblocks
branch
from
b502cfd
to
cc51013
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a rust function that handles multiple blocks at the same time, to minimize the js->rust overhead
Depends on #81