-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 1.5.0 #259
base: master
Are you sure you want to change the base?
Bump to 1.5.0 #259
Conversation
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Just so I know I understand fully, with examples:
Correct? Only thing I'm a bit unclear on currently is when/where i18n "bulk rounds" get merged, Master? Successor? What if both branches had string changes? I also think another "checkbox" should be: "[x] I have updated the translation template with any string changes". - which will prevent awkward cases that someone accidentally hardcodes a string, delaying merge. Otherwise, I like it, and I think I can help automate a lot of this with Prodder by, i.e: automatically compiling an i18n list, pinging the translators for us, pinging the QC team with direct links to the test deployments. |
On the 1st: Create a branch for the upcoming release (1.5 on 2023/12/01), and update package.json on
On
They would end up on
A bump to
Other projects do something like this, check Godot for example. They are developing the The way you outlined would also be good, the main issue is that I expect
Ideally they would be done after the 1st on master, with the Other potential scenarios:
We can merge master into the current stable branch and begin testing, keeping master as
That PR will change |
Abstract
Bump MPW to 1.5.0, to follow this new proposed release model:
Branching:
master
will always push to the future release: We recently released1.4.0
, so we are now developing1.5.x
.Pull request guidelines:
To maintain clarity during the development of both versions:
1.4
master
and have include acherrypick-stable
label. It will be the duty of the PR merger to cherrypick the commit to the stable branch.Additionally, a new section was added to the PR template. This is done mainly to remind developers that the changelog is to be updated per PR, rather than before the release: This allows us to eventually automate the bump version PRs.
Monthly Version Bump and QA
On the 1st of each month:
1.x
, (e.g.1.5
, not1.5.0
). This is because we release the1.x.y
release from the1.x
branch.master
and increase the version by one.This will give us 10 days to fix any bugs that pop up. Any new features merged into master after the first of each month will therefore not make it into the upcoming release.
Translations
A translation PR can be opened after the first of each month, with
master
as the base andcherrypick-stable
as label.Testing
No testing is required.
PR Checklist
I have:
npm run prettier
.