Optimize list of material filters #1464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purely an internal change, i optimizes things like this:
(yes, this is a real filter used in a real map)
By turning this into just one material filter with a composite matcher having a multiple-material-matcher, and an exact material matcher:
What this means is it will be solved in one set-check against materials O(1), and then a follow-up check for the exact stone:6, instead of having to perform up to 50 checks