Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reflection when using SportPaper #1288

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

calcastor
Copy link
Contributor

@calcastor calcastor commented Jan 1, 2024

Depends on Electroid/SportPaper#139

The reflection used in NMSHacks1_8 breaks in modern Java versions, but we can modify SportPaper and avoid that here.

@calcastor calcastor marked this pull request as ready for review January 1, 2024 17:01
@calcastor calcastor requested a review from Electroid as a code owner January 1, 2024 17:01
@calcastor
Copy link
Contributor Author

This has been updated to add a fallback for older versions of SportPaper. However, it does now depend on newer versions of SportPaper to build thus the action failure.

@calcastor calcastor force-pushed the java-17-sportpaper branch 2 times, most recently from 2da97b5 to a8527af Compare January 13, 2024 16:53
@calcastor
Copy link
Contributor Author

@Electroid The relevant PR for this has been merged in SportPaper however it does not seem to be deployed to the Maven repo for SportPaper. Any ideas?

The reflection used in NMSHacks1_8 breaks in modern Java versions, but we can modify SportPaper to avoid that here.

Signed-off-by: BT (calcastor/mame) <[email protected]>
@calcastor calcastor force-pushed the java-17-sportpaper branch from b20fb85 to 6a0c4c9 Compare March 5, 2024 21:49
Signed-off-by: BT (calcastor/mame) <[email protected]>
@calcastor calcastor force-pushed the java-17-sportpaper branch from 6a0c4c9 to 89f10a3 Compare March 5, 2024 21:50
@calcastor
Copy link
Contributor Author

GitHub actions doesn't seem to like the pgm.fyi maven repo, but with snapshots enabled for the SportPaper maven repo the build succeeds here now. That seems to be only permitted for authenticated GitHub users, however the pgm.fyi maven repo does seem to work fine for local builds.

@Pablete1234 Pablete1234 added the ready PR is ready to merge label Mar 5, 2024
@Electroid Electroid merged commit a340985 into PGMDev:dev Mar 10, 2024
2 checks passed
@calcastor calcastor deleted the java-17-sportpaper branch June 14, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR is ready to merge
Development

Successfully merging this pull request may close these issues.

4 participants