PAYOSWXP-125: Shopware 6.6 compatibilty & BugFixes & Cypress-Tests #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ & move from annotion-registration to attribute-registration
rommelfreddy
force-pushed
the
task/PAYOSWXP-125_66x-compatibility
branch
2 times, most recently
from
86d5a75
to
1f2b393
Compare
momocode-de
requested changes
Apr 13, 2024
...nents/GenericExpressCheckout/PaymentHandler/AbstractGenericExpressCheckoutPaymentHandler.php
Show resolved
Hide resolved
+ required for SW6.6 compatibility + fixed configuration validation
invoice: b2b was never allowed (should be allowed if enabled) + add unit-tests + remove not required constraint (which was used for unzer)
+ replaced legacy sw-field component + replaced model binding + add correct content-slot for sw-page + replace component-icon (prev. icon does not exist anymore) + add missing position-identifier
rommelfreddy
force-pushed
the
task/PAYOSWXP-125_66x-compatibility
branch
from
6b05367
to
b351cc9
Compare
…failed test the session shared with all tests, so if the DFP has been added to the session, the next test will fail, because the DFP has been already created. with this change, we will clear the session during GET & add some additional test
…improve transition-assertiation
…ble is empty before testing behaviour
… to prevent orders without payments
frontend issues has been detected by cypress
rommelfreddy
force-pushed
the
task/PAYOSWXP-125_66x-compatibility
branch
3 times, most recently
from
f36d9ee
to
22ebd05
Compare
rommelfreddy
force-pushed
the
task/PAYOSWXP-125_66x-compatibility
branch
from
22ebd05
to
2738659
Compare
& display birthday always (prefilled)
rommelfreddy
force-pushed
the
task/PAYOSWXP-125_66x-compatibility
branch
from
2738659
to
2929345
Compare
rommelfreddy
force-pushed
the
task/PAYOSWXP-125_66x-compatibility
branch
from
ec9e9d6
to
92be8c2
Compare
this will prevent conflicts with normal payment methods
…pdate-payment-page
rommelfreddy
force-pushed
the
task/PAYOSWXP-125_66x-compatibility
branch
2 times, most recently
from
98c99d8
to
12702c6
Compare
momocode-de
previously requested changes
Apr 29, 2024
| } | ||
|
|
||
| /** @var CustomerEntity|null $customer */ | ||
| $customer = $this->customerRepository->search(new Criteria([$customerId]), $context)->first(); |
There was a problem hiding this comment.
If you get to this point, it would make sense to add the “defaultBillingAddress” association here, as you need it in the “getCustomerAddress” function.
There was a problem hiding this comment.
good point! Done.
| protected function saveCustomerData(CustomerEntity $customer, RequestDataBag $dataBag, Context $context): void | ||
| { | ||
| $birthday = $dataBag->get(RequestConstants::BIRTHDAY); | ||
| $birthday = \is_string($birthday) ? \DateTime::createFromFormat('Y-m-d', $birthday) ?: null : null; |
There was a problem hiding this comment.
Can you put the \DateTime::createFromFormat('Y-m-d', $birthday) ?: null in brackets to make it easier to read?
| <service id="PayonePayment\Components\CustomerDataPersistor\CustomerDataPersistor" autowire="true"> | ||
| <argument key="$orderAddressRepository" type="service" id="order_address.repository" /> | ||
| <argument key="$customerRepository" type="service" id="customer.repository" /> | ||
| <argument key="$customerAddressRepository" type="service" id="customer_address.repository" /> |
There was a problem hiding this comment.
If you are using “autowire” anyway, you can actually omit the repository declarations, as autowiring should also work by default for these, if the variables are named accordingly (The way you did it).
There was a problem hiding this comment.
i know. But in the past Shopware does have a few problems with injecting the repositories, so i never used this in production.
my suggestion is to keep it in the backlog and refactoring this on the next SW 6.7 release.
Are you fine with that?
+ move saving to separate class to prevent saving during other request-builder calls + add saving of phonenumber into customer-address (prev. it was only saved into order-address)
rommelfreddy
force-pushed
the
task/PAYOSWXP-125_66x-compatibility
branch
from
d3b990f
to
e19c5b1
Compare
KristinLeupold
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see ticket for more information
PLEASE DO NOT SQUASH!