Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYOSWXP-120: notification targets: log notification target responses to logfile #290

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

amirinterlutions
Copy link
Contributor

PAYOSWXP-120: Adds new log feature: Notification Forward logs are now saved in payone_transaction_forward

@amirinterlutions amirinterlutions self-assigned this Jan 28, 2024
@rommelfreddy rommelfreddy changed the title PAYOSWXP-120: Adds new log feature: Notification Forward logs are now saved in payone_transaction_forward PAYOSWXP-120: notification targets: log notification target responses to logfile Feb 5, 2024
@rommelfreddy
Copy link
Collaborator

@amirinterlutions i rebased your changes on the default branches, and resolved the conflicts.

please have a look into my last commit (in your branch).
I added the correct logger-registration according the documentation: https://developer.shopware.com/docs/guides/plugins/plugins/plugin-fundamentals/logging.html
(I also found this just in the last weeks)

feel free to test again, and verify my changes.

@amirinterlutions
Copy link
Contributor Author

@amirinterlutions i rebased your changes on the default branches, and resolved the conflicts.

please have a look into my last commit (in your branch). I added the correct logger-registration according the documentation: https://developer.shopware.com/docs/guides/plugins/plugins/plugin-fundamentals/logging.html (I also found this just in the last weeks)

feel free to test again, and verify my changes.

@amirinterlutions
Copy link
Contributor Author

Thanks, looks good! I checked it!

@janteuber janteuber merged commit 6b46c16 into master Feb 23, 2024
34 checks passed
@janteuber janteuber deleted the task/PAYOSWXP-120 branch February 23, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants