PAYOSWXP-115: integrate amazon pay payment methods #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rommelfreddy
force-pushed
the
task/PAYOSWSX-115_amazon-pay
branch
from
c51f320
to
b059b39
Compare
momocode-de
requested changes
Jan 17, 2024
tests/Components/GenericExpressCheckout/CustomerRegistrationUtilTest.php
Outdated
Show resolved
Hide resolved
src/EventListener/CheckoutCartAmazonPayExpressEventListener.php
Outdated
Show resolved
Hide resolved
rommelfreddy
force-pushed
the
task/PAYOSWSX-115_amazon-pay
branch
2 times, most recently
from
5cef725
to
bf9f893
Compare
rommelfreddy
force-pushed
the
task/PAYOSWSX-115_amazon-pay
branch
4 times, most recently
from
5c63091
to
61cbfb7
Compare
momocode-de
reviewed
Feb 20, 2024
|
|
||
| $payload = json_decode($payloadJson, true); | ||
| if ($totalAmount === null) { | ||
| $totalAmount = (float)$payload['paymentDetails']['totalOrderAmount']['amount']; |
There was a problem hiding this comment.
Can you be sure that it is always set exactly like this? Should you set a default value or throw an exception if it is not set? (same below)
rommelfreddy
force-pushed
the
task/PAYOSWSX-115_amazon-pay
branch
from
61cbfb7
to
3f5dce8
Compare
momocode-de
previously requested changes
Mar 18, 2024
src/EventListener/CheckoutCartAmazonPayExpressEventListener.php
Outdated
Show resolved
Hide resolved
rommelfreddy
force-pushed
the
task/PAYOSWSX-115_amazon-pay
branch
from
3f5dce8
to
e522438
Compare
janteuber
approved these changes
Mar 22, 2024
rommelfreddy
force-pushed
the
task/PAYOSWSX-115_amazon-pay
branch
from
e522438
to
e82aaba
Compare
…eckout … which is reusable for amazon pay
…stomers got validated with b2c-countries too
…hod and add back-link
rommelfreddy
force-pushed
the
task/PAYOSWSX-115_amazon-pay
branch
from
e82aaba
to
29e0075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE DO NOT SQUASH ON MERGE!