-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAYOSWXP-47: Unzer invoice purchase: if there is no company name in config, paymentmethod should be hidden #280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine for me. But please add a few unit test to make sure
- that if configuration is empty (empty string) the script work as expected
- that if configuration is null the script works as expected
- that if configuration has a value the script works as expected
Hello @amirinterlutions i adjusted your PR. Please verify my adjustments and test, if everything still works fine. |
dc96a4e
to
6c701d9
Compare
@@ -101,7 +101,7 @@ | |||
}, | |||
"consentCheckbox": { | |||
"introduction": "With the transmission of the data necessary for the completion of the invoice purchase, an identity check and credit check to payolution GmbH, Am Euro Platz 2, 1120 Wien I agree.", | |||
"textWithLink": "I can revoke my <a href=\"%link%\" data-url=\"%link%\" data-modal-class=\"payolution\" data-toggle=\"modal\" title=\"Einwilligung\">consent</a> at any time with effect for the future." | |||
"textWithLink": "I can revoke my <a data-toggle=\"modal\" data-bs-toggle=\"modal\" data-url=\"%link%\" href=\"%link%\" title=\"Einwilligung\">consent</a> at any time with effect for the future." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also change this in the de_DE file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! I have made the necessary changes in the de_DE file as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
we should wait for #291. Here are a few changes, which would break, if this PR got merged at first. After 291 got merged, we should do a few little adjustments to fit the changes from 291. |
21e1ecf
to
e9225a1
Compare
@janteuber |
…onfig, paymentmethod should be hidden
…mpany name in config, paymentmethod should be hidden
… to test multiple payment-handlers with one test
… from event-listener to standardized payment-filter functionality
…nsent checkbox text for Germany.
e9225a1
to
8c304cf
Compare
The date of birth should no longer be requested on the payment type page as soon as something has been entered in the Company name field.