Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYOSWXP-47: Unzer invoice purchase: if there is no company name in config, paymentmethod should be hidden #280

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

amirinterlutions
Copy link
Contributor

The date of birth should no longer be requested on the payment type page as soon as something has been entered in the Company name field.

Copy link
Collaborator

@rommelfreddy rommelfreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine for me. But please add a few unit test to make sure

  • that if configuration is empty (empty string) the script work as expected
  • that if configuration is null the script works as expected
  • that if configuration has a value the script works as expected

@rommelfreddy
Copy link
Collaborator

rommelfreddy commented Jan 8, 2024

Hello @amirinterlutions
Hello @momocode-de

i adjusted your PR.
I moved the filter to the payment-filter functionality. which we have added in the past.
additionally i have adjusted an compressed your unit-tests.

Please verify my adjustments and test, if everything still works fine.
Thank you in advance

@rommelfreddy rommelfreddy force-pushed the task/PAYOSWXP-47 branch 2 times, most recently from dc96a4e to 6c701d9 Compare January 8, 2024 18:32
@@ -101,7 +101,7 @@
},
"consentCheckbox": {
"introduction": "With the transmission of the data necessary for the completion of the invoice purchase, an identity check and credit check to payolution GmbH, Am Euro Platz 2, 1120 Wien I agree.",
"textWithLink": "I can revoke my <a href=\"%link%\" data-url=\"%link%\" data-modal-class=\"payolution\" data-toggle=\"modal\" title=\"Einwilligung\">consent</a> at any time with effect for the future."
"textWithLink": "I can revoke my <a data-toggle=\"modal\" data-bs-toggle=\"modal\" data-url=\"%link%\" href=\"%link%\" title=\"Einwilligung\">consent</a> at any time with effect for the future."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also change this in the de_DE file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! I have made the necessary changes in the de_DE file as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@rommelfreddy
Copy link
Collaborator

we should wait for #291. Here are a few changes, which would break, if this PR got merged at first. After 291 got merged, we should do a few little adjustments to fit the changes from 291.

@rommelfreddy
Copy link
Collaborator

@janteuber
please merge #292 at first.
please do not squash the commits on merging!

amirinterlutions and others added 5 commits March 21, 2024 14:28
…mpany name in config, paymentmethod should be hidden
… to test multiple payment-handlers with one test
… from event-listener to standardized payment-filter functionality
@janteuber janteuber merged commit 2ef2255 into master Mar 22, 2024
34 checks passed
@janteuber janteuber deleted the task/PAYOSWXP-47 branch March 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants