Rework all applications to use ArgumentParser #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobianas
force-pushed
the
addPersistanceArgument
branch
7 times, most recently
from
eb72267 to
58da550
Compare
ihrasko
requested changes
Jan 31, 2025
...ces/lighty-network-topology-device/src/main/java/io/lighty/netconf/device/topology/Main.java
Show resolved
Hide resolved
...ces/lighty-network-topology-device/src/main/java/io/lighty/netconf/device/topology/Main.java
Show resolved
Hide resolved
lighty-netconf-device/src/main/java/io/lighty/netconf/device/utils/ArgumentParser.java
Show resolved
Hide resolved
We already used argument parser in toaster-multiple-devices, and using different logic in other applications does not make sense. Standardize all applications to use ArgumentParser to improve future development and add -help function. This change is also crucial in order to add persistence. JIRA: LIGHTY-353 Signed-off-by: tobias.pobocik <[email protected]>
Tobianas
force-pushed
the
addPersistanceArgument
branch
from
58da550 to
53fd13e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already used argument parser in toaster-multiple-devices, and using different logic in other applications does not make sense. Standardize all aplications to use ArgumentParser to improve future development and add -help function and.
This change is also crutial in order to add persistence.
JIRA: LIGHTY-353