Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11371: [OSMaps] - Leaflet center not working as expected #188

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

This PR is for fixing the center update when the map was panned or zoomed, and the markers were presented.

What was happening

  • The center parameter was not respected when the user used the leaflet map with markers.

What was done

  • add a flag to refresh the center position if the user changes the center;
  • Clean and normalize refresh function on both providers;

Test Steps

  1. Go to the sample page, and use the different buttons to change the center;
  2. Interact with both maps and afterward with the buttons;
  3. Check if the maps behave as expected;

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

…y the user;

- clean and normalise refresh function on both providers;
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner November 26, 2024 12:23
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.0% Duplication on New Code (required ≤ 3%)
2 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 5e5bd23 into dev Nov 26, 2024
12 of 13 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-11371 branch November 26, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants