Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4631: improvements to the types in the code #144

Merged
merged 6 commits into from
Oct 31, 2023
Merged

ROU-4631: improvements to the types in the code #144

merged 6 commits into from
Oct 31, 2023

Conversation

rugoncalves
Copy link
Contributor

This PR is for improving the overall code of OutSystems Maps, by removing the type any, and doing small code improvements.

What was happening

  • The usage of any was quite widespread
  • Some lint errors had not been fixed

What was done

  • Replaced the usage of any by appropriate type or simply by unknown
  • Fixing some lint warnings
  • Creating new types
  • Overall small improvements in the code

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.6% 10.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rugoncalves rugoncalves merged commit 777890a into dev Oct 31, 2023
13 of 14 checks passed
@rugoncalves rugoncalves deleted the ROU-4631 branch October 31, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants