RMET-3680 OSInAppBrowserLib-Android - Don't try to resolve activity before opening URL #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where some URLs aren't being open in Custom Tabs and the External Browser by removing the verification made with
canOpenUrl
.Reasoning:
resolveActivity
can returnnull
even if the URL can actually be opened.canOpenUrl
.catch
clauses, maintaining the current behaviour, as the error returned is the same.Context
References: https://outsystemsrd.atlassian.net/browse/RMET-3680
Type of changes
Platforms affected
Tests
Tested in Android 15 (Pixel 7).
MABS 10 build: https://intranet.outsystems.net/MABS/BuildDetail.aspx?BuildId=82ce90ebd3fcd5c99dbdc8f6915324d50410b70a
Screenshots (if appropriate)
Checklist
RNMT-XXXX <title>