ДЗ HomeWork flow - Sergey Kudashkin #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZadorozhnyiSemen
suggested changes
May 1, 2022
|
|
||
| init { | ||
| viewModelScope.launch { | ||
| withContext(Dispatchers.IO) { | ||
| withContext(Dispatchers.Main) { |
There was a problem hiding this comment.
нет нужды, viewmodelscope работает на main диспачере
| @@ -14,8 +19,23 @@ class MainActivity : AppCompatActivity() { | |||
| val view = layoutInflater.inflate(R.layout.activity_main, null) as CatsView | |||
| setContentView(view) | |||
|
|
|||
| catsViewModel.catsLiveData.observe(this){ | |||
| view.populate(it) | |||
| // catsViewModel.catsLiveData.observe(this){ | |||
There was a problem hiding this comment.
неиспользуемый код можно почистить, оставлять за собой порядок - хорошоу
| return flow { | ||
| sampleRepository.produceNumbers().collect { | ||
| emit(it.toString()) | ||
| if(it % 15 == 0) emit("FizzBuzz") |
There was a problem hiding this comment.
Это можно преобразовать в when, чтобы не было такой вложенности if-else
| @@ -48,6 +69,22 @@ class SampleInteractor( | |||
| * При любом исходе, будь то выброс исключения или успешная отработка функции вызовите метод dotsRepository.completed() | |||
| */ | |||
| fun task4(): Flow<Int> { | |||
| return flowOf() | |||
|
|
|||
| return flow { | |||
There was a problem hiding this comment.
тут можно сделать немного элегантнее - sampleRepository.produceNumbers() возвращает flow, поэтому нам не нужно создавать новый flow. после вызова produceNumbers() можно посмотреть в сторону функций Flow.catch и Flow.onCompletion, они покроют 100% требований задачи
ZadorozhnyiSemen
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.