Implement lpe file:line:col and /bin/open file:line:col.

The latter is what Terminal uses when "hyperlinking" to filenames. Fixes HaikuArchives#68.
OscarL · Mar 6, 2024 · f473584 · f473584
1 parent cebd73d
commit f473584
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 23 deletions.
diff --git a/Sources/PApp.cpp b/Sources/PApp.cpp
@@ -684,16 +684,29 @@ void PApp::RefsReceived(BMessage	*inMessage)
 			}
 			else if (inMessage->HasInt32("be:line"))
 			{
-				int32 line;
+				int32 line, column;
 
 				FailOSErr(inMessage->FindInt32("be:line", &line));
 
-				BMessage msg(msg_SelectLines);
-				FailOSErr(msg.AddInt32("from", line));
-				FailOSErr(msg.AddInt32("to", line - 1));
-
 				BMessenger msgr(d->TextView());
-				FailOSErr(msgr.SendMessage(&msg));
+
+				if (inMessage->FindInt32("be:column", &column) == B_OK)
+				{
+					int32 offset = d->TextView()->Column2Offset(line - 1, column - 1);
+					BMessage msg(msg_Select);
+					FailOSErr(msg.AddInt32("anchor", offset));
+					FailOSErr(msg.AddInt32("caret", offset));
+
+					FailOSErr(msgr.SendMessage(&msg));
+				}
+				else
+				{
+					BMessage msg(msg_SelectLines);
+					FailOSErr(msg.AddInt32("from", line));
+					FailOSErr(msg.AddInt32("to", line - 1));
+
+					FailOSErr(msgr.SendMessage(&msg));
+				}
 			}
 		}
 	}
@@ -866,10 +879,26 @@ void PApp::MessageReceived(BMessage *msg)
 				int32 lineNr;
 				if (w && msg->FindInt32("line", &lineNr) == B_OK)
 				{
-					BMessage m(msg_SelectLines);
-					FailOSErr(m.AddInt32("from", lineNr));
-					FailOSErr(m.AddInt32("to", lineNr - 1));
-					w->PostMessage(&m, w->PreferredHandler());
+					int32 colNr;
+					if (msg->FindInt32("column", &colNr) == B_OK)
+					{
+						PDoc *d = dynamic_cast<PDoc*>(OpenWindow(doc));
+						if (d)
+						{
+							int32 offset = d->TextView()->Column2Offset(lineNr - 1, colNr - 1);
+							BMessage m(msg_Select);
+							FailOSErr(m.AddInt32("anchor", offset));
+							FailOSErr(m.AddInt32("caret", offset));
+							w->PostMessage(&m, w->PreferredHandler());
+						}
+					}
+					else
+					{
+						BMessage m(msg_SelectLines);
+						FailOSErr(m.AddInt32("from", lineNr));
+						FailOSErr(m.AddInt32("to", lineNr - 1));
+						w->PostMessage(&m, w->PreferredHandler());
+					}
 				}
 
 				if (w)

diff --git a/lpe/lpe.cpp b/lpe/lpe.cpp
@@ -44,6 +44,7 @@
 #include <Message.h>
 #include <Roster.h>
 #include <String.h>
+#include <StringList.h>
 
 const long msg_CommandLineOpen = 'Cmdl';
 
@@ -53,12 +54,11 @@ static BString sTempFilePath;
 
 void DoError(const char *e, ...);
 void Usage(bool error);
-void OpenInPe(entry_ref& ref, int lineNr);
+void OpenInPe(entry_ref& ref, int lineNr, int colNr=-1);
 
 void Usage(bool error)
 {
-	puts("usage: lpe [--type <fileType>] [file:linenr | +linenr [file] | file] "
-		"...");
+	puts("usage: lpe [--type <fileType>] [file:linenr<:colnr> | +linenr [file] | file] ...");
 	puts("If no file has been specified, copy stdin to a temporary file and");
 	puts("open that. In that case <fileType> specifies the file extension to");
 	puts("be used to help Pe recognize the content type.");
@@ -80,14 +80,17 @@ void DoError(const char *e, ...)
 	exit(1);
 } /* error */
 
-void OpenInPe(entry_ref& doc, int lineNr)
+void OpenInPe(entry_ref& doc, int lineNr, int colNr)
 {
 	BMessage msg(msg_CommandLineOpen), reply;
 	msg.AddRef("refs", &doc);
 
 	if (lineNr >= 0)
 		msg.AddInt32("line", lineNr);
 
+	if (colNr >= 0)
+		msg.AddInt32("column", colNr);
+
 	entry_ref pe;
 	if (be_roster->FindApp("application/x-vnd.beunited.pe", &pe))
 		DoError("Could not find Pe!");
@@ -152,12 +155,11 @@ int main(int argc, char *argv[])
 {
 	int			i = 0;
 	char	 	*p;
-	char		*dpPtr;
 	int			lineNr = -1;
+	int			colNr = -1;
 	status_t	err;
 	BEntry		e;
 	BString		path;
-	int			nr;
 	bool		pathSeen = false;
 	const char*	fileType = NULL;
 
@@ -190,14 +192,19 @@ int main(int argc, char *argv[])
 			{
 				pathSeen = true;
 				path = argv[i];
-				dpPtr = strrchr(argv[i], ':');
-				if (dpPtr != NULL)
+
+				BStringList parts;
+				if (path.Split(":", true, parts) && parts.CountStrings())
 				{
-					nr = strtoul(dpPtr + 1, &p, 10);
-					if (strlen(p) == 0)
+					switch (parts.CountStrings())
 					{
-						path.SetTo(argv[i], dpPtr-argv[i]);
-						lineNr = nr;
+						case 3:
+							colNr = atoi(parts.StringAt(2).String());
+						case 2:
+							lineNr = atoi(parts.StringAt(1).String());
+						case 1:
+							path = parts.StringAt(0);
+						break;
 					}
 				}
 
@@ -209,7 +216,7 @@ int main(int argc, char *argv[])
 				entry_ref ref;
 				err = e.GetRef(&ref);
 				if (err) DoError("Error trying to access file %s, (%s)", path.String(), strerror(err));
-				OpenInPe(ref, lineNr);
+				OpenInPe(ref, lineNr, colNr);
 				lineNr = -1;
 			}
 		}