Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curve AMO #2370

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Curve AMO #2370

wants to merge 16 commits into from

Conversation

clement-ux
Copy link
Contributor

Description

Create a new AMO for Base, on Curve.
Almost same AMO as current Convex AMO (on mainnet), with following exceptions:

  • Depositing LPs on Curve gauge instead of Convex.
  • Use WETH instead of raw ETH.
  • Add _solvencyAssert() from AerodromeAMO logic.

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Copy link

github-actions bot commented Jan 28, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against f353db1

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 153 lines in your changes missing coverage. Please review.

Project coverage is 49.81%. Comparing base (1817476) to head (e54d05a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...acts/contracts/strategies/BaseCurveAMOStrategy.sol 0.00% 153 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2370      +/-   ##
==========================================
- Coverage   52.53%   49.81%   -2.73%     
==========================================
  Files          91       92       +1     
  Lines        4414     4567     +153     
  Branches     1162     1202      +40     
==========================================
- Hits         2319     2275      -44     
- Misses       2092     2289     +197     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clement-ux clement-ux changed the title Clement/base curve amo Curve AMO Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant