Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployed 115 - OUSD YF Upgrade. #2364

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Deployed 115 - OUSD YF Upgrade. #2364

merged 4 commits into from
Feb 4, 2025

Conversation

clement-ux
Copy link
Contributor

@clement-ux clement-ux commented Jan 24, 2025

Deployment

Deploy scripts

  • 115_ousd_upgrade.js

Contracts

Contract Address
OUSD Implementation 0xDbe1c1a3dE56bEA848B4FFd8486dD539E9d490B7

Governance

Proposal payload

  [
    "0x2A8e1E676Ec238d8A992307B495b45B3fEAa5e86"
  ],
  [
    {
      "type": "BigNumber",
      "hex": "0x00"
    }
  ],
  [
    "upgradeTo(address)"
  ],
  [
    "0x000000000000000000000000dbe1c1a3de56bea848b4ffd8486dd539e9d490b7"
  ]
]
0xda95691a00000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000000e0000000000000000000000000000000000000000000000000000000000000012000000000000000000000000000000000000000000000000000000000000001a0000000000000000000000000000000000000000000000000000000000000022000000000000000000000000000000000000000000000000000000000000000010000000000000000000000002a8e1e676ec238d8a992307b495b45b3feaa5e860000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000001275706772616465546f2861646472657373290000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000020000000000000000000000000dbe1c1a3de56bea848b4ffd8486dd539e9d490b7000000000000000000000000000000000000000000000000000000000000001b55706772616465204f55534420746f6b656e20636f6e74726163740000000000

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@clement-ux clement-ux changed the title deploy 115 Deployed 115 - OUSD YF Upgrade. Jan 24, 2025
@clement-ux clement-ux added OUSD OUSD releated things deployment Deploying smart contract labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.80%. Comparing base (aca54e1) to head (905ceed).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2364   +/-   ##
=======================================
  Coverage   50.80%   50.80%           
=======================================
  Files          92       92           
  Lines        4513     4513           
  Branches     1195     1195           
=======================================
  Hits         2293     2293           
  Misses       2217     2217           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clement-ux clement-ux marked this pull request as ready for review January 24, 2025 08:35
@naddison36
Copy link
Collaborator

naddison36 commented Jan 28, 2025

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal
  • The new storage slots are backward compatible with the existing contract.
sol2uml diff 0xDbe1c1a3dE56bEA848B4FFd8486dD539E9d490B7 .,node_modules
Compared the "OUSD" contract with address 0xDbe1c1a3dE56bEA848B4FFd8486dD539E9d490B7 on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   contracts/governance/Governable.sol
match   contracts/token/OUSD.sol

Existing OUSD storage
OUSD_old

New OSDU storage
OUSD_new

naddison36
naddison36 previously approved these changes Jan 28, 2025
Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified the OUSD deployment

Copy link
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

TODO: Try the scripts from PR #2318

@sparrowDom
Copy link
Member

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Perform before/after upgrade balance tests and transfer tests
npx sol2uml diff 0xDbe1c1a3dE56bEA848B4FFd8486dD539E9d490B7 .,node_modules
Compared the "OUSD" contract with address 0xDbe1c1a3dE56bEA848B4FFd8486dD539E9d490B7 on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   contracts/governance/Governable.sol
match   contracts/token/OUSD.sol

sparrowDom
sparrowDom previously approved these changes Jan 28, 2025
@clement-ux clement-ux dismissed stale reviews from sparrowDom and naddison36 via 68993dd January 31, 2025 14:20
@naddison36 naddison36 merged commit abbccea into master Feb 4, 2025
15 of 19 checks passed
@naddison36 naddison36 deleted the clement/deploy_115 branch February 4, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Deploying smart contract OUSD OUSD releated things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants