Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important fixes (v2) #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WarningImHack3r
Copy link

(From elmerfds#305. No other changes were made apart from copying this previous PR.)

This PR does

  • Fix ambigous (and dangerous) behavior during uninstall
  • Global fix for shell formatting
  • Small refactors
  • Fix unhandled cases in yes/no questions
  • Handle uninstallation for certbot via snap or apt

Some notes

  • These changes should probably be applied to CentOS script too. You can use ShellCheck to look for stuff to change, and/or copy the ones I made.
  • There seem to be some other things to remove, such as crontab entry as I've seen, but I didn't dig enough into the script to be sure.
  • And please, never delete folders that may contain anything other than the targeted program, such as important folders like /var/www. If you cannot be sure it won't affect anything else, let the user do it themselves.
    I've lost all my existing websites and certbot certificates because of this script, while it was vaguely mentioning "Web folder" and "Letsencrypt folder". (Fortunately, I had some recent backups)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant